<table><tr><td style="">aacid updated this revision to Diff 15440.<br />aacid added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6207" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Improvements suggested by Laurent</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R91 PIM: Sieve Handling Library</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D6207?vs=15409&id=15440" rel="noreferrer">https://phabricator.kde.org/D6207?vs=15409&id=15440</a></div></div><br /><div><strong>BRANCH</strong><div><div>passwordProviderClass</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6207" rel="noreferrer">https://phabricator.kde.org/D6207</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />

src/ksieveui/CMakeLists.txt<br />

src/ksieveui/debug/sievedebugdialog.cpp<br />

src/ksieveui/debug/sievedebugdialog.h<br />

src/ksieveui/managesievescriptsdialog.cpp<br />

src/ksieveui/managesievescriptsdialog.h<br />

src/ksieveui/util/abstractakonadiimapsettinginterface.cpp<br />

src/ksieveui/util/abstractakonadiimapsettinginterface.h<br />

src/ksieveui/util/akonadiimapsettinginterface.cpp<br />

src/ksieveui/util/akonadiimapsettinginterface.h<br />

src/ksieveui/util/autotests/akonadiimapsettinginterfacetest.cpp<br />

src/ksieveui/util/autotests/akonadiimapsettinginterfacetest.h<br />

src/ksieveui/util/autotests/utilmethodtest.cpp<br />

src/ksieveui/util/sieveimappasswordprovider.h<br />

src/ksieveui/util/util.cpp<br />

src/ksieveui/util/util_p.h<br />

src/ksieveui/vacation/multiimapvacationmanager.cpp<br />

src/ksieveui/vacation/multiimapvacationmanager.h<br />

src/ksieveui/vacation/vacation.cpp<br />

src/ksieveui/vacation/vacation.h<br />

src/ksieveui/vacation/vacationmanager.cpp<br />

src/ksieveui/vacation/vacationmanager.h<br />

src/ksieveui/widgets/custommanagesievewidget.cpp<br />

src/ksieveui/widgets/custommanagesievewidget.h</div></div></div><br /><div><strong>To: </strong>aacid, dvratil, mlaurent<br /><strong>Cc: </strong>KDE PIM, dvasin, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>