<table><tr><td style="">dvratil added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5672" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Thanks!</p>

<p>There is one more place that you could fix just for the sake of semantics: in akonadidb.xml we use QDateTime::currentDateTime() to represent the default value of some columns, you could change that to currentDateTimeUtc() too, and then adjust the code in DbInitializer::sqlValue() accordingly. The "QDateTime::currentDateTime()" here is not executed anywhere, it's only used as a string to represent what the default value is going to be.</p>

<p>An interesting thing to look into could be writing a test to make sure that we correctly process the datetime returned from each database to be in UTC. In the past, there were issues that SQL returned the datetime in UTC, while MySQL in local time without timezone, not sure what PSQL did. I tried to normalize all of these (see Utils::variantToDateTime()) beut it's only used for the generated Entities, not in regular SQL queries. But that's completely out-of-scope fo this change and will probably require a bit of work.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5672#inline-23225" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">protocol.cpp:797</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QDebug</span> <span class="n">dbg</span><span class="p">(</span><span class="n">_dbg</span><span class="p">.</span><span class="n">noquote</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">return</span> <span class="n">dbg</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Item"</span> <span style="color: #aa2211"><<</span> <span class="n">item</span><span class="p">.</span><span class="n">id</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"(RID:"</span> <span style="color: #aa2211"><<</span> <span class="n">item</span><span class="p">.</span><span class="n">remoteId</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">return</span> <span class="n">dbg</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Item<span class="bright">:</span>"</span> <span style="color: #aa2211"><<</span> <span class="n">item</span><span class="p">.</span><span class="n">id</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"(RID:"</span> <span style="color: #aa2211"><<</span> <span class="n">item</span><span class="p">.</span><span class="n">remoteId</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">               <span style="color: #aa2211"><<</span> <span style="color: #766510">", RREV:"</span> <span style="color: #aa2211"><<</span> <span class="n">item</span><span class="p">.</span><span class="n">remoteRevision</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">", mimetype: "</span> <span style="color: #aa2211"><<</span> <span class="n">item</span><span class="p">.</span><span class="n">mimeType</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This seems to have sneaked its way into multiple of your reviews :-) Commit it separately, please.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R165 Akonadi </div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5672" rel="noreferrer">https://phabricator.kde.org/D5672</a></div></div><br /><div><strong>To: </strong>mkoller, dvratil<br /><strong>Cc: </strong>KDE PIM, dvasin, ach, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>