<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5643" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Good idea. I think it would be better to first print the timestamp, then the tag number though, since the tag is part of the command, but the timestamp is part of the log.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5643#inline-23021" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">connection.cpp:226</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">mLogFile</span><span style="color: #aa2211">-></span><span class="n">write</span><span class="p">(</span><span class="n">QByteArray</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">tag</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">mLogFile</span><span style="color: #aa2211">-></span><span class="n">write</span><span class="p">(</span><span class="n">QDateTime</span><span style="color: #aa2211">::</span><span class="n">currentDateTime</span><span class="p">().</span><span class="n">toString</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">" yyyy.MM.dd hh:mm:ss.zzz "</span><span class="p">)).</span><span class="n">toUtf8</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">mLogFile</span><span style="color: #aa2211">-></span><span class="n">write</span><span class="p">(</span><span class="n">Protocol</span><span style="color: #aa2211">::</span><span class="n">debugString</span><span class="p">(</span><span class="n">cmd</span><span class="p">).</span><span class="n">toUtf8</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use QStringLiteral instead of QLatin1String, and maybe use a better date  format? <tt style="background: #ebebeb; font-size: 13px;">yyyy-MM-dd</tt> (ISO) or <tt style="background: #ebebeb; font-size: 13px;">dd.MM.yyyy</tt> (European).</p>

<p style="padding: 0; margin: 8px;">Same below for the client  messages.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R165 Akonadi </div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5643" rel="noreferrer">https://phabricator.kde.org/D5643</a></div></div><br /><div><strong>To: </strong>mkoller, dvratil<br /><strong>Cc: </strong>KDE PIM, dvasin, ach, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>