<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119787/">https://git.reviewboard.kde.org/r/119787/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Patch doesn't apply anymore.</p></pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On August 14th, 2014, 11:54 a.m. UTC, Christian Mollekopf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDEPIM-Libraries.</div>
<div>By Christian Mollekopf.</div>
<p style="color: grey;"><i>Updated Aug. 14, 2014, 11:54 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdepimlibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ETM: Keep track of collectionfetchjobs and only emit collectionTreeFetched once all are done.
Because we need at least two fetch jobs when monitoring collectoins (base + recursive),
the signal was emitted to early, resulting in test continuing before the model
was fully populated. Additionally this allowed to remove another extra
codepath.
ETM: Whenever we insert a new collection we need to populate it.
ETM: Fixed inserts.
The previous code seems bogus. It's always one toplevel parent anyways as it seems.
I introduced the previous code myself in 0dc0c06d74915.
CollectionSync: Keep a hash of the names as well.
During the initial sync we hit this fallback codepath on every collection,
and it comes to a grinding halt with a couple of thousand collections.
With the hash it remains performant and the memory overhead seems relatively small.
ResourceBase: Sync referenced collections.
CollectionComboBox: Set listfilter
CollectionSync: Detect enabled changes.
Collection: Always the changelog to changed when set.
Otherwise setEnabled(true) will still not result in the value getting
updated (since the default value is true as well).
ETM: Removed unnecessary debug output</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>akonadi/collection.cpp <span style="color: grey">(153e4bcf0806f7ae3864890dc01692c7a1376803)</span></li>
<li>akonadi/collectioncombobox.cpp <span style="color: grey">(800d5e6113f09d33494bc0f1eb07a7e23e634386)</span></li>
<li>akonadi/collectionsync.cpp <span style="color: grey">(c9afbfb0a1f25238f3a41d9218d75b47120367c8)</span></li>
<li>akonadi/entitytreemodel.h <span style="color: grey">(a58668e0de7789b6cdcef7ef27243140d2eaad88)</span></li>
<li>akonadi/entitytreemodel_p.h <span style="color: grey">(ba989352989f879e92d644640546a3d259c11212)</span></li>
<li>akonadi/entitytreemodel_p.cpp <span style="color: grey">(8d24973494b78726bdeb4f01990aeab139c4d745)</span></li>
<li>akonadi/resourcebase.cpp <span style="color: grey">(9dbc1878b5e161e4ac9c8939ea65ff77f139815a)</span></li>
<li>akonadi/tests/entitytreemodeltest.cpp <span style="color: grey">(fc6e3be1c471248cdb7c7865b2186373cc53c6fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119787/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>