<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129264/">https://git.reviewboard.kde.org/r/129264/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 27th, 2016, 7:35 a.m. UTC, <b>Daniel Vrátil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129264/diff/1/?file=482974#file482974line352" style="color: black; font-weight: bold; text-decoration: underline;">src/server/storage/dbconfigmysql.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">352</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">mDatabaseProcess</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">finished</span><span class="p">(</span><span class="kt">int</span><span class="p">,</span> <span class="n">QProcess</span><span class="o">::</span><span class="n">ExitStatus</span><span class="p">)),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use the new Qt5 syntax please (i.e. function pointers instead of SIGNAL/SLOT keywords)</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't know how, since:
/home/koller/KDE/source/kde/pim/akonadi/src/server/storage/dbconfigmysql.cpp: In member function ‘virtual bool Akonadi::Server::DbConfigMysql::startInternalServer()’:
/home/koller/KDE/source/kde/pim/akonadi/src/server/storage/dbconfigmysql.cpp:355:54: error: no matching function for call to ‘Akonadi::Server::DbConfigMysql::connect(QProcess<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">&, <unresolved overloaded function type>, Akonadi::Server::DbConfigMysql</em>, void (Akonadi::Server::DbConfigMysql::*)(int, QProcess::ExitStatus))’
this, &DbConfigMysql::processFinished);
^</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is also a deprecated QProcess::finished(int exitCode)</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On October 26th, 2016, 3:04 p.m. UTC, Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Akonadi and Daniel Vrátil.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2016, 3:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
akonadi
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It happened to me that I started kmail but could not see any mail folder.
Searching I found that although all akonadi processes were running, the mysqld process was not,
so it seems for whatever reason mysqld crashed (using a privately started mysqld from akonadiserver).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch checks if the mysqld stops unexpectedly when it was started from akonadiserver and tells the latter to quit when a stopped mysqld was discovered.
Also in this case the local socket file is removed so that a restart can work without problem.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Started akonadi via akonadictl and also implicitely via kmail, then killed (-4, -15) mysqld.
Restarted via akonadictl or kmail</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/server/storage/dbconfigmysql.h <span style="color: grey">(27841e8)</span></li>
<li>src/server/storage/dbconfigmysql.cpp <span style="color: grey">(0962ccb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129264/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>