<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118619/">https://git.reviewboard.kde.org/r/118619/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ceb7bdd423f5ed148b53f422795a167df48ab99e by Martin Steigerwald to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On June 8th, 2014, 5:07 p.m. UTC, Martin Steigerwald wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDEPIM, KDEPIM-Libraries, Albert Astals Cid, Dan Vrátil, and Sergio Luis Martins.</div>
<div>By Martin Steigerwald.</div>
<p style="color: grey;"><i>Updated June 8, 2014, 5:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334218">334218</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdepim-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sort by filename, which is RemoteId, instead of item id to make test pass.
Review request 118441 introduced sorting of items for ItemFetchJob
testcase as due to an performance optimization mixedmaildir resource
does not sort anymore. This fixed the testcase for me on BTRFS.
However on the Jenkins server the test case was still not fixed and
Kevin pointed out that qSort may sort by item id instead of RemoteId.
The test relies on sorting by filename, which is basically the RemoteId.
With the change the test still passes on my BTRFS setup. Yet once
mixedmaildir-storecompacttest test failed. On subsequent runs of
"make test" this didn´t happen again. And storecompacttest is in a different file, so cannot be affected: resources/mixedmaildir/tests/storecompacttest.cpp
This needs to go into KDE SC 4.13.2 to have all test cases of
kdepim-runtime pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">make test after building with the change.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>resources/mixedmaildir/tests/itemfetchtest.cpp <span style="color: grey">(fe034beb396e28b40ef732fb7468ea2b173d9460)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118619/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>