<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118441/">https://git.reviewboard.kde.org/r/118441/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118441/diff/1/?file=276643#file276643line373" style="color: black; font-weight: bold; text-decoration: underline;">resources/mixedmaildir/tests/itemfetchtest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ItemFetchTest::testListingMaildir()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">371</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QVERIFY</span><span class="p">(</span> <span class="o">!</span><span class="n">tagListHash</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span> <span class="n">items</span><span class="p">[</span> <span class="mi">0</span> <span class="p">].</span><span class="n">remoteId</span><span class="p">()</span> <span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">373</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QVERIFY</span><span class="p">(</span> <span class="o">!</span><span class="n">tagListHash</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span> <span class="n">items</span><span class="p">[</span> <span class="mi">0</span> <span class="p">].</span><span class="n">remoteId</span><span class="p">()</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks ok, but I would prefer the sorting to happen right before here where it is needed.
And a comment like this
// TODO: check should not depend on any specific ordering</pre>
</div>
<br />
<p>- Kevin Krammer</p>
<br />
<p>On May 31st, 2014, 6:24 p.m. UTC, Martin Steigerwald wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDEPIM, KDEPIM-Libraries, Dan Vrátil, and Sergio Luis Martins.</div>
<div>By Martin Steigerwald.</div>
<p style="color: grey;"><i>Updated May 31, 2014, 6:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334218">334218</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdepim-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manually sort the item list so that tagListHash.contains tests work
Otherwise the individual tests in this testcase may work on the wrong
mails as libmaildir doesn´t sort the entry list anymore.
This is related to the nosorting change from review request 117975.
This needs to go into 4.13 branch as well before release of 4.13.2.
CCBUG: 334218</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Test passes:
martin@merkaba:~/KDE/Dev/kdepim-runtime/build/resources/mixedmaildir/tests> ./itemfetchtest
********* Start testing of ItemFetchTest *********
Config: Using QTest library 4.8.6, Qt 4.8.6
PASS : ItemFetchTest::initTestCase()
PASS : ItemFetchTest::testListingMaildir()
PASS : ItemFetchTest::testListingMBox()
PASS : ItemFetchTest::testSingleItemFetchMaildir()
QDEBUG : ItemFetchTest::testSingleItemFetchMBox() "201007241551.37547.kevin.krammer@demo.kolab.org"
QDEBUG : ItemFetchTest::testSingleItemFetchMBox() "201007241552.01232.kevin.krammer@demo.kolab.org"
QDEBUG : ItemFetchTest::testSingleItemFetchMBox() "201007241551.16855.kevin.krammer@demo.kolab.org"
QDEBUG : ItemFetchTest::testSingleItemFetchMBox() "201007241550.46907.kevin.krammer@demo.kolab.org"
PASS : ItemFetchTest::testSingleItemFetchMBox()
PASS : ItemFetchTest::cleanupTestCase()
Totals: 6 passed, 0 failed, 0 skipped
********* Finished testing of ItemFetchTest *********</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>resources/mixedmaildir/tests/itemfetchtest.cpp <span style="color: grey">(28a0f6e301968efbed88f53e753fab91c8e083cf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118441/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>