<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118400/">https://git.reviewboard.kde.org/r/118400/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDEPIM, KDEPIM-Libraries, Dan Vrátil, and Sergio Luis Martins.</div>
<div>By Martin Steigerwald.</div>
<p style="color: grey;"><i>Updated May 31, 2014, 6:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">added related bug</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334218">334218</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdepim-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manually sort the QStringList for the readEntryFlags test
Otherwise the individual test in this testcase may work on the wrong
mails as libmaildir doesn´t sort the entry list anymore.
This is related to the nosorting change from review request 117975.
This needs to go into 4.13 branch as well before release of 4.13.2.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The test FlagsReading passes with the fix applied:
martin@merkaba:~/KDE/Dev/kdepim-runtime/build/resources/maildir/libmaildir/tests> ./testmaildir
********* Start testing of MaildirTest *********
Config: Using QTest library 4.8.6, Qt 4.8.6
PASS : MaildirTest::initTestCase()
PASS : MaildirTest::testMaildirInstantiation()
PASS : MaildirTest::testMaildirCreation()
PASS : MaildirTest::testMaildirListing()
PASS : MaildirTest::testMaildirAccess()
PASS : MaildirTest::testMaildirReadHeaders()
PASS : MaildirTest::testMaildirWrite()
PASS : MaildirTest::testMaildirAppend()
QWARN : MaildirTest::testMaildirRemoveEntry() Maildir::readEntry unable to find: "1401378906.R958.merkaba"
PASS : MaildirTest::testMaildirRemoveEntry()
PASS : MaildirTest::testMaildirListSubfolders()
PASS : MaildirTest::testMaildirCreateSubfolder()
PASS : MaildirTest::testMaildirRemoveSubfolder()
PASS : MaildirTest::testMaildirRename()
PASS : MaildirTest::testMaildirMoveTo()
PASS : MaildirTest::testMaildirFlagsReading()
PASS : MaildirTest::testMaildirFlagsWriting()
PASS : MaildirTest::cleanupTestCase()
Totals: 17 passed, 0 failed, 0 skipped
********* Finished testing of MaildirTest *********
I don´t know about the testMaildirRemoveEntry. Maybe there is also some issue with the sorting...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>resources/maildir/libmaildir/tests/testmaildir.cpp <span style="color: grey">(47bc5c99dda020c35ef94c7f319edf2e12e4bf17)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118400/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>