<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129221/">https://git.reviewboard.kde.org/r/129221/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On říjen 19th, 2016, 2:48 odp. UTC, <b>Lamarque Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129221/diff/1/?file=482590#file482590line133" style="color: black; font-weight: bold; text-decoration: underline;">libs/editor/settings/ui/wificonnectionwidget.ui</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">97</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <string>This option locks th<span class="hl">is</span> connection to the Wi-Fi <span class="hl">access point (AP)</span> specified b<span class="hl">y the</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">130</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <string>This option locks th<span class="hl">e</span> connection to the Wi-Fi <span class="hl">network associated to the</span> specified b<span class="hl">and. This setting depends</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This tooltip is not accurate. The wifi network is identified by the ssid and may comprise several access points. This option fixes one of those access points so the wifi card does not jump from one access point to another <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">in the same network</em>.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As far as I know someone can have two or more access points in the same network (same ssid) with the same frequency band (same channel). This setting does not seem band specific to me, so the change "network associated to the specified band" does not seem accurate to me.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's correct, this tooltip is for BSSID, which allows you to force connecting to a certain AP.</p></pre>
<br />
<p>- Jan</p>
<br />
<p>On říjen 19th, 2016, 11:03 dop. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Říj. 19, 2016, 11:03 dop.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">vertical spacing between all widgets set to 6px (previously only few of them had this spacing)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">checkbox alignment according to HIG</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">correct label alignment for some VPN widgets</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/editor/settings/ipv4widget.cpp <span style="color: grey">(2e92061)</span></li>
<li>libs/editor/settings/ipv6widget.cpp <span style="color: grey">(c5fa3b8)</span></li>
<li>libs/editor/settings/ui/802-1x.ui <span style="color: grey">(54ae4fc)</span></li>
<li>libs/editor/settings/ui/bond.ui <span style="color: grey">(1c7d1c3)</span></li>
<li>libs/editor/settings/ui/bridge.ui <span style="color: grey">(61a1db6)</span></li>
<li>libs/editor/settings/ui/bt.ui <span style="color: grey">(295cd9e)</span></li>
<li>libs/editor/settings/ui/cdma.ui <span style="color: grey">(bace7ce)</span></li>
<li>libs/editor/settings/ui/infiniband.ui <span style="color: grey">(a3ab450)</span></li>
<li>libs/editor/settings/ui/ipv4.ui <span style="color: grey">(0aae15e)</span></li>
<li>libs/editor/settings/ui/ipv6.ui <span style="color: grey">(58d0c89)</span></li>
<li>libs/editor/settings/ui/ppp.ui <span style="color: grey">(f53f38b)</span></li>
<li>libs/editor/settings/ui/pppoe.ui <span style="color: grey">(bc6ee35)</span></li>
<li>libs/editor/settings/ui/vlan.ui <span style="color: grey">(1ea5bae)</span></li>
<li>libs/editor/settings/ui/wificonnectionwidget.ui <span style="color: grey">(283cff4)</span></li>
<li>libs/editor/settings/ui/wifisecurity.ui <span style="color: grey">(27610d0)</span></li>
<li>libs/editor/settings/ui/wiredconnectionwidget.ui <span style="color: grey">(c07ae7f)</span></li>
<li>vpn/iodine/iodine.ui <span style="color: grey">(ac92c17)</span></li>
<li>vpn/l2tp/l2tp.ui <span style="color: grey">(3dedc44)</span></li>
<li>vpn/l2tp/l2tpadvanced.ui <span style="color: grey">(80e333f)</span></li>
<li>vpn/l2tp/l2tpauth.ui <span style="color: grey">(a5de7fe)</span></li>
<li>vpn/l2tp/l2tpppp.ui <span style="color: grey">(64ce2ac)</span></li>
<li>vpn/openconnect/openconnectprop.ui <span style="color: grey">(ed7dfde)</span></li>
<li>vpn/openswan/openswan.ui <span style="color: grey">(b5e107d)</span></li>
<li>vpn/openswan/openswanauth.ui <span style="color: grey">(aa7f626)</span></li>
<li>vpn/openvpn/openvpnadvanced.ui <span style="color: grey">(24f7564)</span></li>
<li>vpn/pptp/pptpadvanced.ui <span style="color: grey">(dd51bc7)</span></li>
<li>vpn/pptp/pptpprop.ui <span style="color: grey">(33c1e86)</span></li>
<li>vpn/ssh/sshwidget.ui <span style="color: grey">(95b4b6d)</span></li>
<li>vpn/sstp/sstpadvanced.ui <span style="color: grey">(d198620)</span></li>
<li>vpn/sstp/sstpwidget.ui <span style="color: grey">(c4a0b42)</span></li>
<li>vpn/vpnc/vpnc.ui <span style="color: grey">(ab0ba36)</span></li>
<li>vpn/vpnc/vpncadvanced.ui <span style="color: grey">(9c27f85)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129221/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>