<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129212/">https://git.reviewboard.kde.org/r/129212/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On říjen 20th, 2016, 8:19 dop. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well done. Was able to prove myself wrong about first concerns regarding text length exceeding the dropdown width; bracketed text is most often the second best solution. Perhaps have a closer look on the alignment that might be not perfect on the right (wonder how it looks on resize). Consider to either indent further on the left side so password is aligned with the dropdown above, or just anchor it to the left without indention. Both should work well.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure I can do anything about the alignment, because it's a QStackedWidget where we have nested various widget combinations based on security type. But I'll check that.</p></pre>
<br />
<p>- Jan</p>
<br />
<p>On říjen 18th, 2016, 1:37 odp. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management, KDE Usability, Albert Astals Cid, and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Říj. 18, 2016, 1:37 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As discussed over email, currently the password options (Save, Not Required, Always ask) are not easy to find so we decided to move them back to separated combobox again, ecept moving the combobox below the password field with a better description.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><img alt="Example of wireless setting" src="https://jgrulich.fedorapeople.org/password-field-new.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kded/pinwidget.ui <span style="color: grey">(61c95c0)</span></li>
<li>libs/editor/settings/cdmawidget.cpp <span style="color: grey">(309b6e6)</span></li>
<li>libs/editor/settings/gsmwidget.cpp <span style="color: grey">(de5a7ef)</span></li>
<li>libs/editor/settings/pppoewidget.cpp <span style="color: grey">(1305797)</span></li>
<li>libs/editor/settings/security802-1x.cpp <span style="color: grey">(e5f0307)</span></li>
<li>libs/editor/settings/ui/802-1x.ui <span style="color: grey">(54ae4fc)</span></li>
<li>libs/editor/settings/ui/cdma.ui <span style="color: grey">(bace7ce)</span></li>
<li>libs/editor/settings/ui/gsm.ui <span style="color: grey">(e1c729b)</span></li>
<li>libs/editor/settings/ui/pppoe.ui <span style="color: grey">(bc6ee35)</span></li>
<li>libs/editor/settings/ui/wifisecurity.ui <span style="color: grey">(27610d0)</span></li>
<li>libs/editor/settings/wifisecurity.cpp <span style="color: grey">(fc607eb)</span></li>
<li>libs/editor/widgets/passwordfield.h <span style="color: grey">(627d9b0)</span></li>
<li>libs/editor/widgets/passwordfield.cpp <span style="color: grey">(68aa3b8)</span></li>
<li>vpn/iodine/iodineauth.ui <span style="color: grey">(1dcee23)</span></li>
<li>vpn/l2tp/l2tp.ui <span style="color: grey">(3dedc44)</span></li>
<li>vpn/l2tp/l2tpauth.ui <span style="color: grey">(a5de7fe)</span></li>
<li>vpn/openconnect/openconnectauth.cpp <span style="color: grey">(1602fb8)</span></li>
<li>vpn/openswan/openswan.ui <span style="color: grey">(b5e107d)</span></li>
<li>vpn/openswan/openswanauth.ui <span style="color: grey">(aa7f626)</span></li>
<li>vpn/openvpn/openvpn.ui <span style="color: grey">(f95e466)</span></li>
<li>vpn/openvpn/openvpnadvanced.ui <span style="color: grey">(24f7564)</span></li>
<li>vpn/openvpn/openvpnadvancedwidget.cpp <span style="color: grey">(1dea814)</span></li>
<li>vpn/openvpn/openvpnauth.cpp <span style="color: grey">(c0d2a46)</span></li>
<li>vpn/openvpn/openvpnwidget.cpp <span style="color: grey">(5241883)</span></li>
<li>vpn/pptp/pptpauth.ui <span style="color: grey">(e77a480)</span></li>
<li>vpn/pptp/pptpprop.ui <span style="color: grey">(33c1e86)</span></li>
<li>vpn/pptp/pptpwidget.cpp <span style="color: grey">(dabaa25)</span></li>
<li>vpn/ssh/sshauth.ui <span style="color: grey">(1e4bf62)</span></li>
<li>vpn/ssh/sshwidget.ui <span style="color: grey">(95b4b6d)</span></li>
<li>vpn/sstp/sstpadvanced.ui <span style="color: grey">(d198620)</span></li>
<li>vpn/sstp/sstpauth.ui <span style="color: grey">(2fad484)</span></li>
<li>vpn/sstp/sstpwidget.cpp <span style="color: grey">(f0bf10a)</span></li>
<li>vpn/sstp/sstpwidget.ui <span style="color: grey">(c4a0b42)</span></li>
<li>vpn/strongswan/strongswanauth.ui <span style="color: grey">(d605290)</span></li>
<li>vpn/strongswan/strongswanprop.ui <span style="color: grey">(9ce7376)</span></li>
<li>vpn/vpnc/vpnc.ui <span style="color: grey">(ab0ba36)</span></li>
<li>vpn/vpnc/vpncauth.ui <span style="color: grey">(22a3e4e)</span></li>
<li>vpn/vpnc/vpncwidget.cpp <span style="color: grey">(7c547f9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129212/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>