<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129212/">https://git.reviewboard.kde.org/r/129212/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good to me, I'd "Ship It" it but since there's lots of people in the list of CC, let's let them give their opinion :)</p></pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On October 18th, 2016, 6:40 a.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management, KDE Usability, Albert Astals Cid, and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Oct. 18, 2016, 6:40 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As discussed over email, currently the password options (Save, Not Required, Always ask) are not easy to find so we decided to move them back to separated combobox again, ecept moving the combobox below the password field with a better description.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><img alt="Example of wireless setting" src="https://jgrulich.fedorapeople.org/password-field-new.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/editor/settings/cdmawidget.cpp <span style="color: grey">(309b6e6)</span></li>
<li>libs/editor/settings/gsmwidget.cpp <span style="color: grey">(de5a7ef)</span></li>
<li>libs/editor/settings/pppoewidget.cpp <span style="color: grey">(1305797)</span></li>
<li>libs/editor/settings/security802-1x.cpp <span style="color: grey">(e5f0307)</span></li>
<li>libs/editor/settings/wifisecurity.cpp <span style="color: grey">(fc607eb)</span></li>
<li>libs/editor/widgets/passwordfield.h <span style="color: grey">(627d9b0)</span></li>
<li>libs/editor/widgets/passwordfield.cpp <span style="color: grey">(68aa3b8)</span></li>
<li>vpn/openvpn/openvpnadvancedwidget.cpp <span style="color: grey">(1dea814)</span></li>
<li>vpn/openvpn/openvpnwidget.cpp <span style="color: grey">(5241883)</span></li>
<li>vpn/pptp/pptpwidget.cpp <span style="color: grey">(dabaa25)</span></li>
<li>vpn/sstp/sstpwidget.cpp <span style="color: grey">(f0bf10a)</span></li>
<li>vpn/vpnc/vpncwidget.cpp <span style="color: grey">(7c547f9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129212/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>