<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129212/">https://git.reviewboard.kde.org/r/129212/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129212/diff/1/?file=482395#file482395line25" style="color: black; font-weight: bold; text-decoration: underline;">libs/editor/widgets/passwordfield.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include</span> <span class="cpf"><KLineEdit></span><span class="cp"></span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include</span> <span class="cpf"><KLineEdit></span><span class="cp"></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KLineEdit is deprecated for QLineEdit</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129212/diff/1/?file=482395#file482395line26" style="color: black; font-weight: bold; text-decoration: underline;">libs/editor/widgets/passwordfield.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include</span> <span class="cpf"><KComboBox></span><span class="cp"></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QComboBox ?</p></pre>
</div>
</div>
<br />
<p>- Anthony Fieroni</p>
<br />
<p>On October 18th, 2016, 9:01 a.m. EEST, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management, KDE Usability, Albert Astals Cid, and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Oct. 18, 2016, 9:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As discussed over email, currently the password options (Save, Not Required, Always ask) are not easy to find so we decided to move them back to separated combobox again, ecept moving the combobox below the password field with a better description.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><img alt="Example of wireless setting" src="https://jgrulich.fedorapeople.org/password-field-new.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/editor/settings/cdmawidget.cpp <span style="color: grey">(309b6e6)</span></li>
<li>libs/editor/settings/gsmwidget.cpp <span style="color: grey">(de5a7ef)</span></li>
<li>libs/editor/settings/pppoewidget.cpp <span style="color: grey">(1305797)</span></li>
<li>libs/editor/settings/security802-1x.cpp <span style="color: grey">(e5f0307)</span></li>
<li>libs/editor/settings/wifisecurity.cpp <span style="color: grey">(fc607eb)</span></li>
<li>libs/editor/widgets/passwordfield.h <span style="color: grey">(627d9b0)</span></li>
<li>libs/editor/widgets/passwordfield.cpp <span style="color: grey">(68aa3b8)</span></li>
<li>vpn/openvpn/openvpnadvancedwidget.cpp <span style="color: grey">(1dea814)</span></li>
<li>vpn/openvpn/openvpnwidget.cpp <span style="color: grey">(5241883)</span></li>
<li>vpn/pptp/pptpwidget.cpp <span style="color: grey">(dabaa25)</span></li>
<li>vpn/sstp/sstpwidget.cpp <span style="color: grey">(f0bf10a)</span></li>
<li>vpn/vpnc/vpncwidget.cpp <span style="color: grey">(7c547f9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129212/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>