<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129111/">https://git.reviewboard.kde.org/r/129111/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On říjen 6th, 2016, 1:23 odp. UTC, <b>Lamarque Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129111/diff/1/?file=481763#file481763line31" style="color: black; font-weight: bold; text-decoration: underline;">vpn/iodine/iodine.ui</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <widget class="QLineEdit" name="le_fragmentSize"/></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This should be a spinbox to prevent users from typing non-digit characters and negative numbers.</p></pre>
</blockquote>
<p>On říjen 6th, 2016, 1:39 odp. UTC, <b>Jan Grulich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I implemented this exactly the same way as it is implemented in nm-connection-editor. Do you have idea what would be the minimum and maximum value for this? I couldn't find it in the source code for NetworkManager-iodine plugin.</p></pre>
</blockquote>
<p>On říjen 6th, 2016, 1:58 odp. UTC, <b>Lamarque Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have not found that either. What I have found is that that number is like MTU for ethernet and the smaller that number the more overhead the connection will have. The maximum value should not be big since DNS' packets are not supposed to have a big payload, maybe 2 kbytes at the very most. It is also calculated automatically when it is not set, so maybe we sould add a hint saying that the user should not set that option and allow it to be calculcated automatically for better performance.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I changed the line edit to spinbox with minimum value to be 0 (Automatic) and maximum value 10000 (according to MTU for ethernet).</p></pre>
<br />
<p>- Jan</p>
<br />
<p>On říjen 6th, 2016, 11:09 dop. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Říj. 6, 2016, 11:09 dop.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=367655">367655</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds support for Iodine VPN connections allowing tunnel connections via DNS.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>vpn/CMakeLists.txt <span style="color: grey">(3d3f962)</span></li>
<li>vpn/iodine/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/iodine/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/iodine/iodine.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/iodine/iodine.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/iodine/iodine.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/iodine/iodineauth.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/iodine/iodineauth.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/iodine/iodineauth.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/iodine/iodinewidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/iodine/iodinewidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/iodine/nm-iodine-service.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/iodine/plasmanetworkmanagement_iodineui.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129111/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>