<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128093/">https://git.reviewboard.kde.org/r/128093/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128093/diff/10/?file=468942#file468942line425" style="color: black; font-weight: bold; text-decoration: underline;">src/manager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 10)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">399</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">m_isWimaxEnabled</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">407</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span><span class="hl"> </span><span class="n"><span class="hl">checkVersion</span></span><span class="p"><span class="hl">(</span></span><span class="mi"><span class="hl">1</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="mi"><span class="hl">2</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="mi"><span class="hl">0</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="o"><span class="hl">?</span></span> <span class="nl">m_isWimaxEnabled</span><span class="hl"> </span><span class="p"><span class="hl">:</span></span><span class="hl"> </span><span class="nb"><span class="hl">false</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This should be swapped:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">return checkVersion(1, 2, 0) ? false : m_isWimaxEnabled;</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128093/diff/10/?file=468942#file468942line430" style="color: black; font-weight: bold; text-decoration: underline;">src/manager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 10)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">404</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">m_isWimaxHardwareEnabled</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">412</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span><span class="hl"> </span><span class="n"><span class="hl">checkVersion</span></span><span class="p"><span class="hl">(</span></span><span class="mi"><span class="hl">1</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="mi"><span class="hl">2</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="mi"><span class="hl">0</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="o"><span class="hl">?</span></span> <span class="nl">m_isWimaxHardwareEnabled</span><span class="hl"> </span><span class="p"><span class="hl">:</span></span><span class="hl"> </span><span class="nb"><span class="hl">false</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here too.</p></pre>
</div>
</div>
<br />
<p>- Lamarque Souza</p>
<br />
<p>On June 19th, 2016, 8:03 p.m. UTC, Palo Kisa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management, Jan Grulich and Lamarque Souza.</div>
<div>By Palo Kisa.</div>
<p style="color: grey;"><i>Updated June 19, 2016, 8:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
networkmanager-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://bugs.kde.org/show_bug.cgi?id=362736</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's a relatively big change... so everything needs to be double checked.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(bbd5868)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(0470d8f)</span></li>
<li>src/accesspoint.h <span style="color: grey">(51a1b2f)</span></li>
<li>src/accesspoint.cpp <span style="color: grey">(62cbc6c)</span></li>
<li>src/accesspoint_p.h <span style="color: grey">(521f8ce)</span></li>
<li>src/activeconnection.h <span style="color: grey">(7516ad6)</span></li>
<li>src/activeconnection.cpp <span style="color: grey">(e833f51)</span></li>
<li>src/activeconnection_p.h <span style="color: grey">(79a0055)</span></li>
<li>src/connection.h <span style="color: grey">(5dd7a16)</span></li>
<li>src/connection.cpp <span style="color: grey">(57c5aa0)</span></li>
<li>src/connection_p.h <span style="color: grey">(fb0b90b)</span></li>
<li>src/device.h <span style="color: grey">(f465f78)</span></li>
<li>src/device.cpp <span style="color: grey">(a3f6fad)</span></li>
<li>src/device_p.h <span style="color: grey">(4d7bcb6)</span></li>
<li>src/ipconfig.h <span style="color: grey">(24de6d2)</span></li>
<li>src/ipconfig.cpp <span style="color: grey">(d1316fc)</span></li>
<li>src/manager.h <span style="color: grey">(0f36ba0)</span></li>
<li>src/manager.cpp <span style="color: grey">(bd8752c)</span></li>
<li>src/manager_p.h <span style="color: grey">(8de789d)</span></li>
<li>src/settings.h <span style="color: grey">(76cdd8d)</span></li>
<li>src/settings.cpp <span style="color: grey">(a15165f)</span></li>
<li>src/settings/bondsetting.h <span style="color: grey">(400ed11)</span></li>
<li>src/settings/bondsetting.cpp <span style="color: grey">(3d52611)</span></li>
<li>src/settings/bridgesetting.cpp <span style="color: grey">(05ce74c)</span></li>
<li>src/settings/connectionsettings.h <span style="color: grey">(2dd00af)</span></li>
<li>src/settings/connectionsettings.cpp <span style="color: grey">(b62641e)</span></li>
<li>src/settings/connectionsettings_p.h <span style="color: grey">(d337c99)</span></li>
<li>src/settings/gsmsetting.h <span style="color: grey">(e8dc4ea)</span></li>
<li>src/settings/gsmsetting.cpp <span style="color: grey">(b13274b)</span></li>
<li>src/settings/infinibandsetting.h <span style="color: grey">(c0c854e)</span></li>
<li>src/settings/infinibandsetting.cpp <span style="color: grey">(6ced9b1)</span></li>
<li>src/settings/infinibandsetting_p.h <span style="color: grey">(238cd76)</span></li>
<li>src/settings/setting.cpp <span style="color: grey">(ba75623)</span></li>
<li>src/settings/teamsetting.h <span style="color: grey">(c11e1c6)</span></li>
<li>src/settings/teamsetting.cpp <span style="color: grey">(60ff218)</span></li>
<li>src/settings/tunsetting.cpp <span style="color: grey">(ead153c)</span></li>
<li>src/settings/vlansetting.h <span style="color: grey">(244cef5)</span></li>
<li>src/settings/vlansetting.cpp <span style="color: grey">(5c39dc9)</span></li>
<li>src/settings/wirelesssetting.h <span style="color: grey">(4f84a77)</span></li>
<li>src/settings/wirelesssetting.cpp <span style="color: grey">(aa143c4)</span></li>
<li>src/settings_p.h <span style="color: grey">(aec5423)</span></li>
<li>src/vlandevice.h <span style="color: grey">(cec84ea)</span></li>
<li>src/vlandevice.cpp <span style="color: grey">(029cab0)</span></li>
<li>src/vlandevice_p.h <span style="color: grey">(83b6b6f)</span></li>
<li>src/wimaxdevice.cpp <span style="color: grey">(468f50c)</span></li>
<li>src/wirelessdevice.h <span style="color: grey">(65313a7)</span></li>
<li>src/wirelessdevice.cpp <span style="color: grey">(9439606)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128093/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/54f5a458-701f-4590-b9b4-21ea0c04f682__0001-Make-the-networkmanager-version-checks-in-runtime.patch">0001-Make-the-networkmanager-version-checks-in-runtime.patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>