<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126398/">https://git.reviewboard.kde.org/r/126398/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) This patch improves SsidCombobox to send ssidChanged() signal just once and not three times as it was before. Previously this signal was send in onCurrentIndexChanged() (second call) which calls setEditText() and thus editTextChanged() sent it one more time (third call) and the very first one was again in editTextChanged() which was called internally once user picked up any SSID from the combobox and this one included the ugly SSID name in format "ssid (%xx), Security: foo, Frequency: bar" which is the reason why I added check for this text in editTextChanged() to avoid sending this one. Another improvement in SsidCombobox is that it nows properly reloads BSSID combobox once SSID is changed by either selecting any SSID from the list or by writing any text into the SSID field.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">2) Adds detection for wireless security based on selected SSID</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with all security types (WEP/WPA/WPA Enterprise) and seems to work, also the SSID combobox now sends the ssidChanged() signal just once with correct SSID.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/editor/connectiondetaileditor.cpp <span style="color: grey">(7370bbb)</span></li>
<li>libs/editor/settings/wificonnectionwidget.h <span style="color: grey">(a111b7a)</span></li>
<li>libs/editor/settings/wificonnectionwidget.cpp <span style="color: grey">(a36b661)</span></li>
<li>libs/editor/widgets/ssidcombobox.h <span style="color: grey">(3e367e7)</span></li>
<li>libs/editor/widgets/ssidcombobox.cpp <span style="color: grey">(472384f)</span></li>
<li>libs/editor/settings/wifisecurity.h <span style="color: grey">(2bef9c5)</span></li>
<li>libs/editor/settings/wifisecurity.cpp <span style="color: grey">(a6c252e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126398/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>