<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126049/">https://git.reviewboard.kde.org/r/126049/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Lamarque Souza</p>
<br />
<p>On November 13th, 2015, 9:50 p.m. UTC, Nick Shaforostoff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management, Jan Grulich and Lamarque Souza.</div>
<div>By Nick Shaforostoff.</div>
<p style="color: grey;"><i>Updated Nov. 13, 2015, 9:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">apart from qstringliteral/qlatin1string/qstringref related optimization,
i have changed context menu code from exec() to popup() and made it delete itself once the menu is closed</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">also note the simplicity of using chop() instead of remove()</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiled and launched, opened connection context menu</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>editor/connectioneditor.cpp <span style="color: grey">(0eaeafe)</span></li>
<li>editor/main.cpp <span style="color: grey">(a5ec1e2)</span></li>
<li>kded/notification.cpp <span style="color: grey">(508443e)</span></li>
<li>kded/passworddialog.cpp <span style="color: grey">(56db793)</span></li>
<li>kded/pindialog.cpp <span style="color: grey">(83553f0)</span></li>
<li>kded/secretagent.cpp <span style="color: grey">(5fc3ee4)</span></li>
<li>kded/service.cpp <span style="color: grey">(8b4048d)</span></li>
<li>libs/editor/simpleipv4addressvalidator.cpp <span style="color: grey">(1e7f240)</span></li>
<li>libs/editor/simpleipv6addressvalidator.cpp <span style="color: grey">(5b87d69)</span></li>
<li>libs/editor/vpnuiplugin.cpp <span style="color: grey">(1dd7b53)</span></li>
<li>libs/models/networkmodelitem.cpp <span style="color: grey">(5182f04)</span></li>
<li>libs/uiutils.cpp <span style="color: grey">(7ad2903)</span></li>
<li>vpn/openconnect/openconnectauth.cpp <span style="color: grey">(a987031)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126049/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>