<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125356/">https://git.reviewboard.kde.org/r/125356/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Lamarque Souza</p>
<br />
<p>On September 23rd, 2015, 10:34 a.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2015, 10:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=351191">351191</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds dependency on QCA which is used for validation of private key in TLS EAP method. It now checks whether the private key is in PKCS12 format and if can be decrypted with given private key password. If it's in PKCS12 format, the same path for the private key is also set as the client certificate path, because it's bundled with the private key (BUG 351191). If the private key is PEM file (.pem, .key) it just checks whether the private key can be decrypted with given private key password. I didn't find out the way how to open private keys in DER format yet, but I read that it's mostly used in Windows anyway. Also, if the private key is not in PKCS12 format, we also have to check whether the client certificate is set.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5d00936)</span></li>
<li>libs/editor/CMakeLists.txt <span style="color: grey">(facc5e5)</span></li>
<li>libs/editor/settings/security802-1x.cpp <span style="color: grey">(88cbf36)</span></li>
<li>libs/editor/settings/ui/802-1x.ui <span style="color: grey">(525c644)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125356/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>