<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125281/">https://git.reviewboard.kde.org/r/125281/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On září 18th, 2015, 12:26 odp. UTC, <b>Lamarque Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125281/diff/2/?file=404661#file404661line83" style="color: black; font-weight: bold; text-decoration: underline;">libs/editor/settings/security802-1x.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Security8021x::Security8021x(const NetworkManager::Security8021xSetting::Ptr &setting, bool wifiMode, QWidget *parent) :</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">83</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">altSubjectValidator</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QRegExpValidator</span><span class="p">(</span><span class="n">QRegExp</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="s">"^(DNS:[a-zA-Z0-9_-]+</span><span class="se">\\</span><span class="s">.[a-zA-Z0-9_.-]+|EMAIL:[a-zA-Z0-9._-]+@[a-zA-Z0-9_-]+</span><span class="se">\\</span><span class="s">.[a-zA-Z0-9_.-]+|URI:[a-zA-Z0-9._-]+:.+|)$"</span><span class="p">)),</span> <span class="k">this</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">According to [1] scheme does not allow underscore character (_) but allows minus (-) and plus (+). There should be double slash after the scheme.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[1] https://tools.ietf.org/html/rfc3986#section-3.1</p></pre>
</blockquote>
<p>On září 22nd, 2015, 7:38 dop. UTC, <b>Jan Grulich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I changed double score character to plus, but if I get it correctly, the double slash is optional and doesn't need to be there, which should be already covered.
See https://en.wikipedia.org/wiki/Uniform_Resource_Identifier</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">s/double score/underscore/</p></pre>
<br />
<p>- Jan</p>
<br />
<p>On září 22nd, 2015, 7:39 dop. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management, Lukáš Tinkl and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Zář. 22, 2015, 7:39 dop.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=342728">342728</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) Adds options to set subjectMatch and altSubjectMatch properties (taken from the old NM applet)
- bug 342728 - Security bug/Regression: altSubjectMatch disappeared with the move to plasma-nm</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">2) Adds WPA/WPA2 Enterprise validation (done according to nm-connection-editor). It's not complete for TLS, I found out that we need to also check private key and get its format to know whether we need client certificate or not, because it might be set already by private key if it's in NM_SETTING_802_1X_CK_FORMAT_PKCS12 format. I would need more time to implement this and verify if I implemented it correctly so that's why I'm sending this part to review first. This should also fix bug 351191 where I think that the problem is that we don't set client certificate if private key is in NM_SETTING_802_1X_CK_FORMAT_PKCS12 format.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/editor/CMakeLists.txt <span style="color: grey">(22b7eca)</span></li>
<li>libs/editor/listvalidator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/editor/listvalidator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/editor/settings/security802-1x.h <span style="color: grey">(22c78fa)</span></li>
<li>libs/editor/settings/security802-1x.cpp <span style="color: grey">(0f8f71d)</span></li>
<li>libs/editor/settings/ui/802-1x.ui <span style="color: grey">(ac5732a)</span></li>
<li>libs/editor/settings/wifisecurity.cpp <span style="color: grey">(b2b80fb)</span></li>
<li>libs/editor/widgets/editlistdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/editor/widgets/editlistdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125281/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>