<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125281/">https://git.reviewboard.kde.org/r/125281/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management, Lukáš Tinkl and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Zář. 22, 2015, 7:39 dop.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove leftover from my unfinished work using qca for certificate validation etc.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=342728">342728</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) Adds options to set subjectMatch and altSubjectMatch properties (taken from the old NM applet)
- bug 342728 - Security bug/Regression: altSubjectMatch disappeared with the move to plasma-nm</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">2) Adds WPA/WPA2 Enterprise validation (done according to nm-connection-editor). It's not complete for TLS, I found out that we need to also check private key and get its format to know whether we need client certificate or not, because it might be set already by private key if it's in NM_SETTING_802_1X_CK_FORMAT_PKCS12 format. I would need more time to implement this and verify if I implemented it correctly so that's why I'm sending this part to review first. This should also fix bug 351191 where I think that the problem is that we don't set client certificate if private key is in NM_SETTING_802_1X_CK_FORMAT_PKCS12 format.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/editor/CMakeLists.txt <span style="color: grey">(22b7eca)</span></li>
<li>libs/editor/listvalidator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/editor/listvalidator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/editor/settings/security802-1x.h <span style="color: grey">(22c78fa)</span></li>
<li>libs/editor/settings/security802-1x.cpp <span style="color: grey">(0f8f71d)</span></li>
<li>libs/editor/settings/ui/802-1x.ui <span style="color: grey">(ac5732a)</span></li>
<li>libs/editor/settings/wifisecurity.cpp <span style="color: grey">(b2b80fb)</span></li>
<li>libs/editor/widgets/editlistdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/editor/widgets/editlistdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125281/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>