<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125233/">https://git.reviewboard.kde.org/r/125233/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On září 15th, 2015, 11:34 dop. UTC, <b>Lamarque Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Stefan Winter <stefan dot winter at restena dot lu> or <swinter at kde dot org>, who also helped in Eduroam specification, once said this about system ca certificates: "I meant the "Use System CA Certs". That option makes no sense in WiFi Enterprise auth; there's actually a reason why none of the big supplicants allows to set that (Windows by default <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">un-checks</em> all CAs in its system store, and you have to enable the one that matches your server cert; and Mac OS always warns you about a new certificate as it comes in <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">unless</em> you used the Profile installation tool and you have put exactly the CAs you trust into the profile." Please add him to this review request.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It seems he doesn't have active developer account so I don't know how to add him to this review, but I can forward the email with this review to him. Regarding usage of that option, I implemented it because it's also present in the latest nm-connection-editor so I suppose it's used by NetworkManager, they just have it as "No CA certificate is required" so it has a different meaning there, but I guess they set "system-ca-certs" property anyway. I'll check that further while waiting for Stefan's response.</p></pre>
<br />
<p>- Jan</p>
<br />
<p>On září 15th, 2015, 6:23 dop. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management, Lukáš Tinkl and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Zář. 15, 2015, 6:23 dop.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As summary says, this patch adds option to use system certificates for WPA/WPA2 Enteprise setting, namely for PEAP, TLS and TTLS.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/editor/settings/security802-1x.cpp <span style="color: grey">(0f8f71d)</span></li>
<li>libs/editor/settings/ui/802-1x.ui <span style="color: grey">(ac5732a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125233/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>