<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121304/">https://git.reviewboard.kde.org/r/121304/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Lamarque Souza</p>
<br />
<p>On December 1st, 2014, 1:52 p.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management, Lukáš Tinkl and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Dec. 1, 2014, 1:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libnm-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As David Edmunson suggested, I removed all propertiesChanged() slots from all classes and moved them to their private classes. This needs to be properly checked if I didn't break anything.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I also properly implemented all virtual devices to match the implementation of other devices.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm using it now with plasma-nm and it seems to work as before.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/wirelessnetwork.h <span style="color: grey">(b78a64b)</span></li>
<li>src/olpcmeshdevice.cpp <span style="color: grey">(814026c)</span></li>
<li>src/olpcmeshdevice_p.h <span style="color: grey">(da436d9)</span></li>
<li>src/teamdevice.h <span style="color: grey">(85ab0f6)</span></li>
<li>src/teamdevice.cpp <span style="color: grey">(8de1df1)</span></li>
<li>src/teamdevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tundevice.h <span style="color: grey">(fcd1138)</span></li>
<li>src/tundevice.cpp <span style="color: grey">(dcfdbe4)</span></li>
<li>src/tundevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/vethdevice.h <span style="color: grey">(bcf17d8)</span></li>
<li>src/vethdevice.cpp <span style="color: grey">(edab51e)</span></li>
<li>src/vethdevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/vlandevice.h <span style="color: grey">(eca01bf)</span></li>
<li>src/vlandevice.cpp <span style="color: grey">(8f5a1fc)</span></li>
<li>src/vlandevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/vpnconnection.h <span style="color: grey">(eae7a26)</span></li>
<li>src/vpnconnection.cpp <span style="color: grey">(3015835)</span></li>
<li>src/vpnconnection_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/wimaxdevice.h <span style="color: grey">(c7a616c)</span></li>
<li>src/wimaxdevice.cpp <span style="color: grey">(4d9cb66)</span></li>
<li>src/wimaxdevice_p.h <span style="color: grey">(1aa767b)</span></li>
<li>src/wimaxnsp.h <span style="color: grey">(92f114c)</span></li>
<li>src/wimaxnsp.cpp <span style="color: grey">(47ca40b)</span></li>
<li>src/wimaxnsp_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/wireddevice.h <span style="color: grey">(c3a91da)</span></li>
<li>src/wireddevice.cpp <span style="color: grey">(7835763)</span></li>
<li>src/wireddevice_p.h <span style="color: grey">(72411a2)</span></li>
<li>src/wirelessdevice.h <span style="color: grey">(ce68244)</span></li>
<li>src/wirelessdevice.cpp <span style="color: grey">(c80ff22)</span></li>
<li>src/wirelessdevice_p.h <span style="color: grey">(63c403b)</span></li>
<li>src/dhcp6config_p.h <span style="color: grey">(e287d6a)</span></li>
<li>src/genericdevice.h <span style="color: grey">(d954c9e)</span></li>
<li>src/genericdevice.cpp <span style="color: grey">(d940f42)</span></li>
<li>src/genericdevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/gredevice.h <span style="color: grey">(6472b0e)</span></li>
<li>src/gredevice.cpp <span style="color: grey">(d9468aa)</span></li>
<li>src/gredevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/infinibanddevice.h <span style="color: grey">(152c773)</span></li>
<li>src/infinibanddevice.cpp <span style="color: grey">(ea04ebd)</span></li>
<li>src/infinibanddevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/macvlandevice.h <span style="color: grey">(19111c1)</span></li>
<li>src/macvlandevice.cpp <span style="color: grey">(ef7f521)</span></li>
<li>src/macvlandevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/modemdevice.h <span style="color: grey">(0205f48)</span></li>
<li>src/modemdevice.cpp <span style="color: grey">(6d6ba04)</span></li>
<li>src/modemdevice_p.h <span style="color: grey">(beaf2a6)</span></li>
<li>src/olpcmeshdevice.h <span style="color: grey">(b08813b)</span></li>
<li>CMakeLists.txt <span style="color: grey">(941d006)</span></li>
<li>src/accesspoint.h <span style="color: grey">(b4b08e7)</span></li>
<li>src/accesspoint.cpp <span style="color: grey">(b058bbd)</span></li>
<li>src/accesspoint_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/activeconnection.h <span style="color: grey">(91c192c)</span></li>
<li>src/activeconnection.cpp <span style="color: grey">(278ab12)</span></li>
<li>src/activeconnection_p.h <span style="color: grey">(fb726af)</span></li>
<li>src/adsldevice.h <span style="color: grey">(fb4f44b)</span></li>
<li>src/adsldevice.cpp <span style="color: grey">(102db82)</span></li>
<li>src/adsldevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/bluetoothdevice.h <span style="color: grey">(ac7014a)</span></li>
<li>src/bluetoothdevice.cpp <span style="color: grey">(e22bdcf)</span></li>
<li>src/bluetoothdevice_p.h <span style="color: grey">(201944a)</span></li>
<li>src/bonddevice.h <span style="color: grey">(5756fc4)</span></li>
<li>src/bonddevice.cpp <span style="color: grey">(d83b141)</span></li>
<li>src/bonddevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/bridgedevice.h <span style="color: grey">(a0fb3ac)</span></li>
<li>src/bridgedevice.cpp <span style="color: grey">(e9dae46)</span></li>
<li>src/bridgedevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/connection.h <span style="color: grey">(8b83f29)</span></li>
<li>src/connection.cpp <span style="color: grey">(a2b8afd)</span></li>
<li>src/connection_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/device.h <span style="color: grey">(2013d1f)</span></li>
<li>src/device.cpp <span style="color: grey">(b87b0a8)</span></li>
<li>src/device_p.h <span style="color: grey">(059f6ef)</span></li>
<li>src/dhcp4config.h <span style="color: grey">(9f87b10)</span></li>
<li>src/dhcp4config.cpp <span style="color: grey">(da92b02)</span></li>
<li>src/dhcp6config.h <span style="color: grey">(7f4d528)</span></li>
<li>src/dhcp6config.cpp <span style="color: grey">(a4a41fc)</span></li>
<li>src/dhcp4config_p.h <span style="color: grey">(8c1bb68)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121304/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>