<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107249/">http://git.reviewboard.kde.org/r/107249/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107249/diff/6/?file=95586#file95586line39" style="color: black; font-weight: bold; text-decoration: underline;">applet/qml/NMPopup.qml</a>
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> property int minimumHeight: Math.max(buttonHeight * 14, interfaceDetails.height)</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This line should be changed to:
property int minimumHeight: Math.max(buttonHeight * 14, interfaceDetails.height + 2 * spacing)
or the interfaceDetails is not fully visible here.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107249/diff/6/?file=95586#file95586line40" style="color: black; font-weight: bold; text-decoration: underline;">applet/qml/NMPopup.qml</a>
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> property int minimumWidth: leftViewWidth + (spacing * 2) + (state == "InitialState" ? 0 : separator.width + spacing + rightViewWidth)</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">leftViewWidth and rightViewWidth are inverted here.</pre>
</div>
<br />
<p>- Lamarque Vieira</p>
<br />
<p>On November 20th, 2012, 11:35 p.m., Michael Zanetti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Michael Zanetti.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2012, 11:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This makes the arthur branch usable on high-res screens.
The QML interface really didn't adapt itself to different sizes at all. I had to change quite a bit. It could be that I changed the look of some small parts a little bit on my way, but I tried to keep the interface as much as possible to what it looked like before. It should be quite easy now to change the overall sizes by changing leftViewWidth, rightViewWidth and minimumHeight in NMPopup.qml.
The sizes of the UI elements are taken from a standard Plasma button and all the list items etc are adjusted to that. This way the items also scale nicely when the theme requires bigger buttons.
Hope this helps.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applet/qml/ConnectionItem.qml <span style="color: grey">(a9d1b6d)</span></li>
<li>applet/qml/ConnectionsListWidget.qml <span style="color: grey">(1ee6428)</span></li>
<li>applet/qml/ConnectionsTabWidget.qml <span style="color: grey">(63a2913)</span></li>
<li>applet/qml/DisconnectButton.qml <span style="color: grey">(43bdcbe)</span></li>
<li>applet/qml/GsmNetworkIcon.qml <span style="color: grey">(71154dc)</span></li>
<li>applet/qml/GsmNetworkItem.qml <span style="color: grey">(3a4463a)</span></li>
<li>applet/qml/HiddenWirelessNetwork.qml <span style="color: grey">(2e20417)</span></li>
<li>applet/qml/InterfaceItem.qml <span style="color: grey">(6ce74b2)</span></li>
<li>applet/qml/InterfacesListWidget.qml <span style="color: grey">(3d0ea88)</span></li>
<li>applet/qml/ModemInterfaceItem.qml <span style="color: grey">(22a3c3f)</span></li>
<li>applet/qml/NMPopup.qml <span style="color: grey">(31a33c6)</span></li>
<li>applet/qml/VpnInterfaceItem.qml <span style="color: grey">(c06e6ef)</span></li>
<li>applet/qml/VpnNetworkItem.qml <span style="color: grey">(66c81a4)</span></li>
<li>applet/qml/WiredInterfaceIcon.qml <span style="color: grey">(915518a)</span></li>
<li>applet/qml/WiredInterfaceItem.qml <span style="color: grey">(6be0f3c)</span></li>
<li>applet/qml/WiredNetworkIcon.qml <span style="color: grey">(c0c8ca9)</span></li>
<li>applet/qml/WiredNetworkItem.qml <span style="color: grey">(046d02b)</span></li>
<li>applet/qml/WirelessInterfaceIcon.qml <span style="color: grey">(dabebd1)</span></li>
<li>applet/qml/WirelessInterfaceItem.qml <span style="color: grey">(15ee0f1)</span></li>
<li>applet/qml/WirelessNetworkIcon.qml <span style="color: grey">(b3bd523)</span></li>
<li>applet/qml/WirelessNetworkItem.qml <span style="color: grey">(90d5e8a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107249/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>