<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106961/">http://git.reviewboard.kde.org/r/106961/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106961/diff/2/?file=91646#file91646line176" style="color: black; font-weight: bold; text-decoration: underline;">applet/interfacedetailswidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">InterfaceDetailsWidget::InterfaceDetailsWidget(QGraphicsItem * parent) : QGraphicsWidget(parent, 0),</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">176</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_backButton</span><span class="o">-></span><span class="n">setMaximumHeight</span><span class="p">(</span><span class="mi">22</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">176</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_backButton</span><span class="o">-></span><span class="n">setMaximumHeight</span><span class="p">(</span><span class="n">QFontMetrics</span><span class="p">(</span><span class="n">KGlobalSettings</span><span class="o">::</span><span class="n">generalFont</span><span class="p">()).</span><span class="n">height</span><span class="p">()</span> <span class="o">+</span> <span class="n">QFontMetrics</span><span class="p">(</span><span class="n">KGlobalSettings</span><span class="o">::</span><span class="n">generalFont</span><span class="p">()).</span><span class="n">xHeight</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can save this value in a temporary variable and use it in the line below instead of calculating it twice.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106961/diff/2/?file=91648#file91648line244" style="color: black; font-weight: bold; text-decoration: underline;">applet/nmpopup.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void NMPopup::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">244</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_advancedSettingsButton</span><span class="o">-></span><span class="n">setMinimumHeight</span><span class="p">(</span><span class="mi">28</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">244</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_advancedSettingsButton</span><span class="o">-></span><span class="n">setMinimumHeight</span><span class="p">(</span><span class="n">QFontMetrics</span><span class="p">(</span><span class="n">KGlobalSettings</span><span class="o">::</span><span class="n">generalFont</span><span class="p">()).</span><span class="n">height</span><span class="p">()</span> <span class="o">+</span> <span class="n">QFontMetrics</span><span class="p">(</span><span class="n">KGlobalSettings</span><span class="o">::</span><span class="n">generalFont</span><span class="p">()).</span><span class="n">xHeight</span><span class="p">()</span> <span class="o">*</span> <span class="mi">2</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same here. Actually you already calculated this value some lines above, you can reuse it instead of calculating it again.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106961/diff/2/?file=91648#file91648line257" style="color: black; font-weight: bold; text-decoration: underline;">applet/nmpopup.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void NMPopup::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">257</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_showInterfacesButton</span><span class="o">-></span><span class="n">setMinimumHeight</span><span class="p">(</span><span class="mi">28</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">257</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_showInterfacesButton</span><span class="o">-></span><span class="n">setMinimumHeight</span><span class="p">(</span><span class="n">QFontMetrics</span><span class="p">(</span><span class="n">KGlobalSettings</span><span class="o">::</span><span class="n">generalFont</span><span class="p">()).</span><span class="n">height</span><span class="p">()</span> <span class="o">+</span> <span class="n">QFontMetrics</span><span class="p">(</span><span class="n">KGlobalSettings</span><span class="o">::</span><span class="n">generalFont</span><span class="p">()).</span><span class="n">xHeight</span><span class="p">()</span> <span class="o">*</span> <span class="mi">2</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">here too.</pre>
</div>
<br />
<p>- Lamarque Vieira</p>
<br />
<p>On October 21st, 2012, 12:09 p.m., Michael Zanetti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Michael Zanetti.</div>
<p style="color: grey;"><i>Updated Oct. 21, 2012, 12:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some more fixes for Retina screen. Because the font scales with the DPI it doesn't fit any more on the hardcoded button sizes. Here are example screenshots:
http://notyetthere.org/data/kde/nm-fixed-sizes.png
http://notyetthere.org/data/kde/nm-dynamic-sizes.png</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applet/activatableitem.cpp <span style="color: grey">(1198fd2)</span></li>
<li>applet/interfacedetailswidget.cpp <span style="color: grey">(9635559)</span></li>
<li>applet/interfaceitem.cpp <span style="color: grey">(356c285)</span></li>
<li>applet/nmpopup.cpp <span style="color: grey">(a8dfd54)</span></li>
<li>applet/wirelessinterfaceitem.cpp <span style="color: grey">(8f71b20)</span></li>
<li>applet/wirelessnetworkitem.cpp <span style="color: grey">(6489f5d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106961/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>