<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106852/">http://git.reviewboard.kde.org/r/106852/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106852/diff/1/?file=89653#file89653line290" style="color: black; font-weight: bold; text-decoration: underline;">device.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">289</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">DeviceStateReason</span><span class="p">(</span><span class="k">const</span> <span class="n">DeviceStateReason</span><span class="o">&</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">constructors must be listed before the destructor.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106852/diff/1/?file=89654#file89654line33" style="color: black; font-weight: bold; text-decoration: underline;">device.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace NetworkManager</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">{</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove trailing white-space.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106852/diff/1/?file=89654#file89654line62" style="color: black; font-weight: bold; text-decoration: underline;">device.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace NetworkManager</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">62</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">delete</span> <span class="n">d</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Constructor NetworkManager::DeviceStateReason::DeviceStateReason() does not allocate d pointer, this delete will likely cause a crash if that constructor is used. By the way, why that costructor is needed anyway?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106852/diff/1/?file=89654#file89654line77" style="color: black; font-weight: bold; text-decoration: underline;">device.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace NetworkManager</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">77</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">*</span><span class="n">d</span> <span class="o">=</span> <span class="o">*</span><span class="n">other</span><span class="p">.</span><span class="n">d</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you should test if other != *this before doing this.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106852/diff/1/?file=89654#file89654line227" style="color: black; font-weight: bold; text-decoration: underline;">device.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void NetworkManager::Device::setAutoconnect(const QVariant & autoconnect)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">225</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">deviceIface</span><span class="p">.</span><span class="n">setAutoconnect</span><span class="p">(</span><span class="n">autoconnect</span><span class="p">.</span><span class="n">toBool</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you can use d->autoconnect instead of autonnect.toBool() here to avoid one more casting.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106852/diff/1/?file=89656#file89656line156" style="color: black; font-weight: bold; text-decoration: underline;">manager.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace NetworkManager {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">156</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Return the network device referenced by its IP</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add to this comment that interface names are operating system dependent. Programs that use this method will not be portable.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106852/diff/1/?file=89662#file89662line86" style="color: black; font-weight: bold; text-decoration: underline;">wirelessdevice.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">86</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * @param options Options of scan</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What are the valid values for options? Is there any documentation in NetworkManager web site about that? If so you can add the url here.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106852/diff/1/?file=89662#file89662line88" style="color: black; font-weight: bold; text-decoration: underline;">wirelessdevice.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">88</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">requestScan</span><span class="p">(</span><span class="n">QVariantMap</span> <span class="o">&</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">although it is not necessary write the parameter name here. It is being referenced by the comment, so it looks better if you do it.</pre>
</div>
<br />
<p>- Lamarque Vieira</p>
<br />
<p>On October 14th, 2012, 3:47 p.m., Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management and Lamarque Vieira Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Oct. 14, 2012, 3:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch updates libnm-qt against new NetworkManager</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0a8ab22)</span></li>
<li>activeconnection.h <span style="color: grey">(1a0867f)</span></li>
<li>activeconnection.cpp <span style="color: grey">(4869de8)</span></li>
<li>activeconnection_p.h <span style="color: grey">(59e545a)</span></li>
<li>dbus/generic-types.h <span style="color: grey">(6544b39)</span></li>
<li>dbus/generic-types.cpp <span style="color: grey">(95427d1)</span></li>
<li>dbus/introspection/nm-active-connection.xml <span style="color: grey">(c8bc08f)</span></li>
<li>dbus/introspection/nm-agent-manager.xml <span style="color: grey">(0b1e3e6)</span></li>
<li>dbus/introspection/nm-device-wifi.xml <span style="color: grey">(3acd3c9)</span></li>
<li>dbus/introspection/nm-device.xml <span style="color: grey">(144c71b)</span></li>
<li>dbus/introspection/nm-manager.xml <span style="color: grey">(13da873)</span></li>
<li>dbus/introspection/nm-secret-agent.xml <span style="color: grey">(7786a76)</span></li>
<li>dbus/introspection/nm-settings.xml <span style="color: grey">(d0a1433)</span></li>
<li>dbus/introspection/nm-vpn-plugin.xml <span style="color: grey">(c7530b3)</span></li>
<li>dbus/nm-access-pointinterface.h <span style="color: grey">(2d00925)</span></li>
<li>dbus/nm-access-pointinterface.cpp <span style="color: grey">(c491b74)</span></li>
<li>dbus/nm-active-connectioninterface.h <span style="color: grey">(bb58e11)</span></li>
<li>dbus/nm-active-connectioninterface.cpp <span style="color: grey">(c77a6a2)</span></li>
<li>dbus/nm-agent-managerinterface.h <span style="color: grey">(9cbfc24)</span></li>
<li>dbus/nm-agent-managerinterface.cpp <span style="color: grey">(02dd79c)</span></li>
<li>dbus/nm-device-btinterface.h <span style="color: grey">(e0a35c1)</span></li>
<li>dbus/nm-device-btinterface.cpp <span style="color: grey">(9a78d08)</span></li>
<li>dbus/nm-device-ethernetinterface.h <span style="color: grey">(9c9790f)</span></li>
<li>dbus/nm-device-ethernetinterface.cpp <span style="color: grey">(7f979b7)</span></li>
<li>dbus/nm-device-modeminterface.h <span style="color: grey">(550fff4)</span></li>
<li>dbus/nm-device-modeminterface.cpp <span style="color: grey">(5f9bcf6)</span></li>
<li>dbus/nm-device-olpc-meshinterface.h <span style="color: grey">(bb26e8c)</span></li>
<li>dbus/nm-device-olpc-meshinterface.cpp <span style="color: grey">(4d46db4)</span></li>
<li>dbus/nm-device-wifiinterface.h <span style="color: grey">(c026a96)</span></li>
<li>dbus/nm-device-wifiinterface.cpp <span style="color: grey">(4a883e1)</span></li>
<li>dbus/nm-device-wimaxinterface.h <span style="color: grey">(9f8373a)</span></li>
<li>dbus/nm-device-wimaxinterface.cpp <span style="color: grey">(6d388f1)</span></li>
<li>dbus/nm-deviceinterface.h <span style="color: grey">(f2107d3)</span></li>
<li>dbus/nm-deviceinterface.cpp <span style="color: grey">(8aad0e4)</span></li>
<li>dbus/nm-dhcp4-configinterface.h <span style="color: grey">(0f5fe52)</span></li>
<li>dbus/nm-dhcp4-configinterface.cpp <span style="color: grey">(05e9aab)</span></li>
<li>dbus/nm-dhcp6-configinterface.h <span style="color: grey">(cd155ac)</span></li>
<li>dbus/nm-dhcp6-configinterface.cpp <span style="color: grey">(2784a82)</span></li>
<li>dbus/nm-ip4-configinterface.h <span style="color: grey">(11776bb)</span></li>
<li>dbus/nm-ip4-configinterface.cpp <span style="color: grey">(d9809a9)</span></li>
<li>dbus/nm-ip6-configinterface.h <span style="color: grey">(dcdef9d)</span></li>
<li>dbus/nm-ip6-configinterface.cpp <span style="color: grey">(f0a3f15)</span></li>
<li>dbus/nm-managerinterface.h <span style="color: grey">(8bef738)</span></li>
<li>dbus/nm-managerinterface.cpp <span style="color: grey">(19172ec)</span></li>
<li>dbus/nm-secret-agentadaptor.h <span style="color: grey">(26be7a6)</span></li>
<li>dbus/nm-secret-agentadaptor.cpp <span style="color: grey">(a111d45)</span></li>
<li>dbus/nm-settings-connectioninterface.h <span style="color: grey">(58fdcc6)</span></li>
<li>dbus/nm-settings-connectioninterface.cpp <span style="color: grey">(f1514cb)</span></li>
<li>dbus/nm-settingsinterface.h <span style="color: grey">(87f74d7)</span></li>
<li>dbus/nm-settingsinterface.cpp <span style="color: grey">(06a8ff2)</span></li>
<li>dbus/nm-vpn-connectioninterface.h <span style="color: grey">(41e6fc3)</span></li>
<li>dbus/nm-vpn-connectioninterface.cpp <span style="color: grey">(7219529)</span></li>
<li>dbus/nm-vpn-managerinterface.h <span style="color: grey">(806303d)</span></li>
<li>dbus/nm-vpn-plugininterface.h <span style="color: grey">(787df1a)</span></li>
<li>dbus/nm-vpn-plugininterface.cpp <span style="color: grey">(338bf3f)</span></li>
<li>dbus/nm-wimax-nspinterface.h <span style="color: grey">(447ee90)</span></li>
<li>dbus/nm-wimax-nspinterface.cpp <span style="color: grey">(afc1533)</span></li>
<li>device.h <span style="color: grey">(9323495)</span></li>
<li>device.cpp <span style="color: grey">(958602f)</span></li>
<li>device_p.h <span style="color: grey">(a9640b7)</span></li>
<li>manager.h <span style="color: grey">(b2029bb)</span></li>
<li>manager.cpp <span style="color: grey">(5cf3266)</span></li>
<li>manager_p.h <span style="color: grey">(bb377bd)</span></li>
<li>settings.h <span style="color: grey">(818ef5b)</span></li>
<li>settings.cpp <span style="color: grey">(0c76d51)</span></li>
<li>settings_p.h <span style="color: grey">(1f6900b)</span></li>
<li>wirelessdevice.h <span style="color: grey">(b7ff859)</span></li>
<li>wirelessdevice.cpp <span style="color: grey">(925d744)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106852/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>