<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105324/">http://git.reviewboard.kde.org/r/105324/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 8th, 2012, 8:25 p.m., <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you check if your ifdefs are properly working?
On my machine, NM happily compiles but then refuses to create any connection (dropped me back in my workplan an entire week). When I removed that patch, it worked fine again. </pre>
</blockquote>
<p>On July 14th, 2012, 2:22 a.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you have firewalld installed? The patch should not affect anyone without firewalld installed (like me).</pre>
</blockquote>
<p>On July 14th, 2012, 2:23 a.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have just pushed a fix for the problem. Please test and check if it works now.</pre>
</blockquote>
<p>On July 19th, 2012, 1:17 p.m., <b>Raymond Wooninck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Lamarque,
I am running PNM on openSUSE Factory (12.2) and am 100% sure that I do not have firewalld installed. However even with the current latest snapshot from GIT, I can not add any new connections. Even trying to add a wired connection through the Network Settings KCM fails with the error message "error adding connection". Existing connections can be used, but new ones cannot be saved. </pre>
</blockquote>
<p>On July 19th, 2012, 1:48 p.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have just pushed a new fix, git pull and try again. In case of master you also must update QtNetworkManager (former libnm-qt).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Lamarque,
After this latest update I am able to create new connections again. So I guess we can mark this little bugger as fixed. Thanks for your support.</pre>
<br />
<p>- Raymond</p>
<br />
<p>On June 25th, 2012, 10:41 a.m., Lukáš Tinkl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management and Lamarque Vieira Souza.</div>
<div>By Lukáš Tinkl.</div>
<p style="color: grey;"><i>Updated June 25, 2012, 10:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">NetworkManager has had support for FirewallD [1] and Network Zones [2]
since [3].
This patch adds one combo box that enables to change the network zone.
This box is visible only when FirewallD is running.
[1] https://fedorahosted.org/firewalld/
[2] https://fedoraproject.org/wiki/Features/network-zones
[3] http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1c0aeb457546ac5e485ca21dfe23f1a009912701
(on behalf of Jiri Popelka <jpopelka@redhat.com>)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/NetworkManager/connectiondbus.cpp <span style="color: grey">(4649a19)</span></li>
<li>libs/internals/connection.h <span style="color: grey">(485b810)</span></li>
<li>libs/internals/connection.cpp <span style="color: grey">(67f31bc)</span></li>
<li>libs/ui/connection.ui <span style="color: grey">(7b9f873)</span></li>
<li>libs/ui/connectionwidget.h <span style="color: grey">(aac7050)</span></li>
<li>libs/ui/connectionwidget.cpp <span style="color: grey">(f67f157)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105324/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>