<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105324/">http://git.reviewboard.kde.org/r/105324/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 26th, 2012, 11:06 a.m., <b>Commit Hook</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 71cff79a2128b6e62e61555cc38383196bbeb540 by Lukas Tinkl to branch nm09.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This commit caused build failure. I committed a fix, please review if the UI patch is correct.</pre>
<br />
<p>- Christoph</p>
<br />
<p>On June 25th, 2012, 10:41 a.m., Lukáš Tinkl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management and Lamarque Vieira Souza.</div>
<div>By Lukáš Tinkl.</div>
<p style="color: grey;"><i>Updated June 25, 2012, 10:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">NetworkManager has had support for FirewallD [1] and Network Zones [2]
since [3].
This patch adds one combo box that enables to change the network zone.
This box is visible only when FirewallD is running.
[1] https://fedorahosted.org/firewalld/
[2] https://fedoraproject.org/wiki/Features/network-zones
[3] http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1c0aeb457546ac5e485ca21dfe23f1a009912701
(on behalf of Jiri Popelka <jpopelka@redhat.com>)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/NetworkManager/connectiondbus.cpp <span style="color: grey">(4649a19)</span></li>
<li>libs/internals/connection.h <span style="color: grey">(485b810)</span></li>
<li>libs/internals/connection.cpp <span style="color: grey">(67f31bc)</span></li>
<li>libs/ui/connection.ui <span style="color: grey">(7b9f873)</span></li>
<li>libs/ui/connectionwidget.h <span style="color: grey">(aac7050)</span></li>
<li>libs/ui/connectionwidget.cpp <span style="color: grey">(f67f157)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105324/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>