<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104979/">http://git.reviewboard.kde.org/r/104979/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By David Woodhouse.</div>
<p style="color: grey;"><i>Updated May 18, 2012, 11:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Requested fixes pushed to both master and nm09 branches in the git tree, and new patch attached with post-review (I think).
Thanks for the review. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes three issues with the OpenConnect VPN support:
- A pending connection attempt cannot be cancelled, occasionally causing kded to lock up while waiting for it. This has been reported by users when behind a captive portal which accepts HTTPS connections but never does anything else, causing the connection attempt never to complete.
- The XML configuration file listing the available VPN servers was not being parsed correctly, and the originally configured server wasn't being de-duplicated from that list.
- Selecting a host in the combobox did not start a connection.
The post-review seems to have submitted all three in one patch; separate commits are at http://git.infradead.org/users/dwmw2/networkmanagement.git
Tested against the Fedora 16 0.9.0.2 package, with OpenConnect 3.19 (and I'm about to release OpenConnect 3.20 because 3.19 introduced a stupid bug which occasionally breaks the KDE authentication dialog.)
Is the nm09 branch still active? These patches seem to apply cleanly both to master and nm09.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Connecting to $EMPLOYER's VPN, selecting different hosts from the list (now that the list works), and observing a successful cancellation instead of having to (press a button and) wait for the connection to complete each time.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>vpnplugins/openconnect/openconnectauth.cpp <span style="color: grey">(4f9cea7330b6004027df7acb0507fe902e112498)</span></li>
<li>vpnplugins/openconnect/openconnectauthworkerthread.h <span style="color: grey">(dc251885c54e050daabe25f7be9e7af5d79bc785)</span></li>
<li>vpnplugins/openconnect/openconnectauthworkerthread.cpp <span style="color: grey">(23d8731a46dd3d7e89dafef2da5f7d90f309f8eb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104979/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>