<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104349/">http://git.reviewboard.kde.org/r/104349/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104349/diff/2/?file=55346#file55346line170" style="color: black; font-weight: bold; text-decoration: underline;">settings/config/mobileconnectionwizard.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MobileConnectionWizard::initializePage(int id)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">169</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">label</span> <span class="o">+=</span> <span class="s">" ("</span><span class="o">+</span><span class="n">apn</span><span class="p">[</span><span class="s">"apn"</span><span class="p">].</span><span class="n">toString</span><span class="p">()</span><span class="o">+</span><span class="sc">')'</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The word "Default" should be the one between parentheses, that is how it is usually done. Besides, it is inconsitent showing the plan name between parentheses here and not in the lines above.
Also, when creating a patch specify in reviewboard's head what branch is applies to.</pre>
</div>
<br />
<p>- Lamarque Vieira</p>
<br />
<p>On April 1st, 2012, 6:06 a.m., Swami Dhyan Nataraj [Nikolay Shaplov] wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management and Lamarque Vieira Souza.</div>
<div>By Swami Dhyan Nataraj [Nikolay Shaplov].</div>
<p style="color: grey;"><i>Updated April 1, 2012, 6:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a kind of concept how to internationalize list of APNs in mobile connection wizard.
This concept uses less CPU and more memory (through this task is not resourse critical). It create a list of apn's QVatiant map once, and then uses it all the time till the end. I thought it is better then reparse XML each time we need an APL info.
If there are ant comments, I will try to do fixes. If no, and everything is OK, I will remove all commented out code from the patch, and let's commit it :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>settings/config/mobileconnectionwizard.h <span style="color: grey">(77fdf56cdf1f9093bcb7052a6a19e6b1bb5ea184)</span></li>
<li>settings/config/mobileconnectionwizard.cpp <span style="color: grey">(1b31c59e0133d931723f0c98902828d98a36aea4)</span></li>
<li>settings/config/mobileproviders.h <span style="color: grey">(72189133fdb6e64edd3ca7736bdc4a2c4954d585)</span></li>
<li>settings/config/mobileproviders.cpp <span style="color: grey">(1ef26fcddeded9e612571a3fd4d1e0771e763bce)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104349/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>