<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104141/">http://git.reviewboard.kde.org/r/104141/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 3rd, 2012, 1:57 p.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104141/diff/2/?file=51665#file51665line73" style="color: black; font-weight: bold; text-decoration: underline;">libs/ui/vpnpreferences.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">VpnPreferences::VpnPreferences(const QVariantList &args, QWidget *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ipv4Setting</span><span class="o">-></span><span class="n">setNeverdefault</span><span class="p">(</span> <span class="k">static_cast</span><span class="o"><</span><span class="kt">bool</span><span class="o">></span><span class="p">(</span><span class="n">ipv4Data</span><span class="p">[</span><span class="n">QLatin1String</span><span class="p">(</span><span class="n">NM_SETTING_IP4_CONFIG_NEVER_DEFAULT</span><span class="p">)].</span><span class="n">toUInt</span><span class="p">())</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's ok now.
I tried to test the patch but it seem NetworkManager is refusing to accept the route configuration from Plasma NM. That is not the fault of your patch but I cannot add new routes to test your patch.
The message "NetworkManager[9513]: nm_ip4_route_set_prefix: assertion `prefix <= 32' failed" appears in the log when I try to add new routes (for examploe 192.168.2.0/255.255.255.0 through gateway 192.168.1.1). 255.255.255.0 == prefix 0 and 0 is < 32, I do not know why this is happening. It would be better if the error messages printed the wrong prefix, but whatever.
I will have to fix that problem first before I can test your patch.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nevermind, downgrading to NetworkManager 0.9.2.0 fixed the issue. Well, NM is not doing so well, I used using a git version from 0.9.3 something, I tried to upgrade to fix that problem but then NM 0.9.3.995 simply does not start here. Downgrading was the solution.
I tested your patch, it seems to work. Can you update the OpenVPN export/import code to support this feature? can you provide a patch against master too?</pre>
<br />
<p>- Lamarque Vieira</p>
<br />
<p>On March 3rd, 2012, 1:43 p.m., Rajeesh K Nambiar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Rajeesh K Nambiar.</div>
<p style="color: grey;"><i>Updated March 3, 2012, 1:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Import/Export Routes setting for VPN connections from/to configuration files. Please review the Gateway/Metrics part in particular.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested the import/export part, Routes appear properly in the new connection. I don't have a real configuration file to test :-/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/ui/vpnpreferences.cpp <span style="color: grey">(9afc6f2)</span></li>
<li>settings/config/manageconnectionwidget.cpp <span style="color: grey">(caa2e06)</span></li>
<li>vpnplugins/vpnc/CMakeLists.txt <span style="color: grey">(5af39b9)</span></li>
<li>vpnplugins/vpnc/vpnc.cpp <span style="color: grey">(79f62ec)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104141/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>