<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102827/">http://git.reviewboard.kde.org/r/102827/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 13th, 2011, 5:32 p.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch works, but the icon for unknown access technology is too similar to nm-applet's wifi icon and may cause confusion. Maybe we should add an interrogation sign (?) to indicate the unknown access technology.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it's common fashion to have that antenna with "rounded waves" as WiFi icon and the staircase bars as mobile, it's found that way on most (if not all) smartphones.
Concerning that access technology: I did not want to confuse users with unneccessary details, I think people don't care about access technology. If it is known, it will be displayed, if it is not known, I doubt it would do anything except for adding clutter/distraction if there was a question mark at that position.</pre>
<br />
<p>- Kai Uwe</p>
<br />
<p>On October 13th, 2011, 8:38 a.m., Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Oct. 13, 2011, 8:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As I now use a Surfstick to get to the internet, I found it handy to see the signal strength right in system tray like WiFi connections do, rather than opening the popup all the time.
This patch resolves this issue by making the system tray show the signal strength as well as the access technology (Edge, umts, etc) in a similar way like Plasma Active's (fake?) mobilesignal widget does, where I also borrowed the graphics from :P
I currently only respected the Plasma SVG icon case, i.e. when you do not use SVG graphics, it uses the generic phone icon still, as we do not yet have a icon naming spec for such cases and do not have icons either, so the tooltip and popup have the generic phone icon.
I added the HSDPA and 3G strength icons to the network.svgz icon file from network manager. See attachments.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles and works okay.
It is not yet perfect but I think it is a good start.
Known issues:
- The strength indicator is only updated if you click (hover?) the system tray icon. The konsole output states that the signals "Solid::Control::ModemGsmNetworkInterface::signalQualityChanged()" do not exist (but I don't know why?) and thus not being triggered
- When not connected, there is either no icon at all (I wanted to use the no-wifi connected icon as fallback) or the 3G with 50% strength (this is weird)
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=283776">283776</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applet/networkmanager.cpp <span style="color: grey">(8c2dc2e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102827/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102827/s/289/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/10/11/hsdpathing_400x100.png" style="border: 1px black solid;" alt="HSDPA tray icon" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>