<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102059/">http://git.reviewboard.kde.org/r/102059/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think we are good to go. Lamarque, what do you say?</pre>
<br />
<p>- Ilia</p>
<br />
<p>On July 25th, 2011, 6 a.m., Rajeesh K Nambiar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Rajeesh K Nambiar.</div>
<p style="color: grey;"><i>Updated July 25, 2011, 6 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Caveat emptor: There is one unresolved issue with isEncrypted() function - we need to check of key file is PKCS12 format or not. nm-applet achieves this through a call to nm_setting_802_1x_set_private_key(). I've googled a lot, and looks like there is no way to check PKCS12 file format in either Qt or KDE.
If we are to add ad-hoc support via SEC_PKCS12DecoderStart and related functions from nss (which is what NetworkManager does), it wil introduce a new dependency on nss-devel.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only lightly tested, seems to import/export OK for sample configuration file. I don't have an OpenVPN connection, so it would be great if someone could test.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=194099">194099</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/ui/vpnuiplugin.h <span style="color: grey">(932d86f)</span></li>
<li>settings/config/manageconnectionwidget.h <span style="color: grey">(8f7a205)</span></li>
<li>settings/config/manageconnectionwidget.cpp <span style="color: grey">(780d50f)</span></li>
<li>vpnplugins/novellvpn/novellvpn.h <span style="color: grey">(a95926b)</span></li>
<li>vpnplugins/novellvpn/novellvpn.cpp <span style="color: grey">(61d5519)</span></li>
<li>vpnplugins/openconnect/openconnectui.h <span style="color: grey">(8098aec)</span></li>
<li>vpnplugins/openconnect/openconnectui.cpp <span style="color: grey">(4d43afd)</span></li>
<li>vpnplugins/openvpn/openvpn.h <span style="color: grey">(4607cd5)</span></li>
<li>vpnplugins/openvpn/openvpn.cpp <span style="color: grey">(6f126b8)</span></li>
<li>vpnplugins/pptp/pptp.h <span style="color: grey">(e513d3c)</span></li>
<li>vpnplugins/pptp/pptp.cpp <span style="color: grey">(e4efbd7)</span></li>
<li>vpnplugins/strongswan/strongswan.h <span style="color: grey">(d648217)</span></li>
<li>vpnplugins/strongswan/strongswan.cpp <span style="color: grey">(9d4a8be)</span></li>
<li>vpnplugins/vpnc/vpnc.h <span style="color: grey">(0b3f6db)</span></li>
<li>vpnplugins/vpnc/vpnc.cpp <span style="color: grey">(ea24cf1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102059/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>