<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101419/">http://git.reviewboard.kde.org/r/101419/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ec6e54763c009867444a6780322d75a289055642 by Lamarque V. Souza.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 5th, 2011, 6:45 a.m., Rajeesh K Nambiar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Rajeesh K Nambiar.</div>
<p style="color: grey;"><i>Updated June 5, 2011, 6:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First stab at VPN connection import/export functionality. Currently implemented just VPNC Import support. Please review, especially the VpncUiPluginPrivate part which tries to abstract away cisco password decrypt function. If the general approach looks good, I'll proceed with this and try to extend for other VPN methods, as well as export function.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested against latest git snapshot, with KDE SC 4.6.3</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=146159">146159</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/internals/settings/vpnsecrets.h <span style="color: grey">(96803ec)</span></li>
<li>libs/ui/vpnpreferences.cpp <span style="color: grey">(843636c)</span></li>
<li>libs/ui/vpnuiplugin.h <span style="color: grey">(7a13027)</span></li>
<li>settings/config/CMakeLists.txt <span style="color: grey">(783d551)</span></li>
<li>settings/config/addeditdeletebuttonset.h <span style="color: grey">(f7abef7)</span></li>
<li>settings/config/addeditdeletebuttonset.cpp <span style="color: grey">(4f3f97a)</span></li>
<li>settings/config/manageconnectionwidget.h <span style="color: grey">(e6f1b93)</span></li>
<li>settings/config/manageconnectionwidget.cpp <span style="color: grey">(dad1676)</span></li>
<li>vpnplugins/novellvpn/novellvpn.h <span style="color: grey">(9e026e2)</span></li>
<li>vpnplugins/novellvpn/novellvpn.cpp <span style="color: grey">(848b527)</span></li>
<li>vpnplugins/openvpn/openvpn.h <span style="color: grey">(a06b88e)</span></li>
<li>vpnplugins/openvpn/openvpn.cpp <span style="color: grey">(60376ed)</span></li>
<li>vpnplugins/pptp/pptp.h <span style="color: grey">(66ea79a)</span></li>
<li>vpnplugins/pptp/pptp.cpp <span style="color: grey">(c311f9f)</span></li>
<li>vpnplugins/strongswan/strongswan.h <span style="color: grey">(fcd5bde)</span></li>
<li>vpnplugins/strongswan/strongswan.cpp <span style="color: grey">(5bffc2b)</span></li>
<li>vpnplugins/vpnc/nm-vpnc-service.h <span style="color: grey">(e3f859a)</span></li>
<li>vpnplugins/vpnc/vpnc.h <span style="color: grey">(aec2136)</span></li>
<li>vpnplugins/vpnc/vpnc.cpp <span style="color: grey">(deb9108)</span></li>
<li>vpnplugins/vpnc/vpncprop.ui <span style="color: grey">(92093cf)</span></li>
<li>vpnplugins/vpnc/vpncwidget.cpp <span style="color: grey">(171d68b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101419/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>