<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101354/">http://git.reviewboard.kde.org/r/101354/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101354/diff/1/?file=16414#file16414line212" style="color: black; font-weight: bold; text-decoration: underline;">settings/config/manageconnectionwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ManageConnectionWidget::restoreUserConnections()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">212</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">type</span> <span class="o">=</span> <span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="s">"Type"</span><span class="p">,</span> <span class="n">QString</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">212</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">type<span class="hl">String</span></span> <span class="o">=</span> <span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="s">"Type"</span><span class="p">,</span> <span class="n">QString</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You must not save a translatable type in configuration file. If the user changes translation between two Plasma NM starts that could accidently changes the scope of the connections. That is the reason why scope was treated as English string.
Or you always save the English string or the enum type converted to int. I prefer to save the enum type converted to int, that is less error prone.</pre>
</div>
<br />
<p>- Lamarque Vieira</p>
<br />
<p>On May 13th, 2011, 1:31 p.m., Gökcen Eraslan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management and Lamarque Vieira Souza.</div>
<div>By Gökcen Eraslan.</div>
<p style="color: grey;"><i>Updated May 13, 2011, 1:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">2 things are done with this patch:
* "System" and "User" keywords are not translatable and hardcoded. There is a Knm::Connection::scopeAsString method but it's not used in anywhere. Patch makes use of it and also change this method to use i18ned words. Now I can see translated uses of System and User words in UI.
* A little refactoring done in settings/config/manageconnectionwidget.cpp to remove excessive usage of Knm::Connection::typeAsString. I've used the enum value of Type to use a switch-case structure instead of string comparison with if-elses.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did not encountered with an error.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/internals/connection.h <span style="color: grey">(bb7e21b)</span></li>
<li>libs/internals/connection.cpp <span style="color: grey">(7085b1b)</span></li>
<li>settings/config/manageconnectionwidget.cpp <span style="color: grey">(6d3dd44)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101354/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>