<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101274/">http://git.reviewboard.kde.org/r/101274/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 96060f9ac3e73b4a32a48e69138bdfcb14d7b910 by Rafael Fernández López.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 2nd, 2011, 3:01 p.m., Rafael Fernández López wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Rafael Fernández López.</div>
<p style="color: grey;"><i>Updated May 2, 2011, 3:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am unable to create/modify/delete any kind of connection using the network manager applet on nm09 branch. I am using Arch Linux, and network manager version 0.8.998 (0.9).
I don't know if this is a distribution issue, or just some kind of difference between small networkmanager versions. However, it seems like 'org.freedesktop.NetworkManager.settings.modify.system' is the correct policy to ask for when creating/modifying or deleting system wide connections, instead of 'org.freedesktop.network-manager-settings.system.modify'.
With this patch, polkit-kde shows up requesting my password without any problems. With the unpatched version I get (depending on the action), but something like: "Adding connection failed. Error code is 0/2 ().".
It seems that Networkmanager developers updated this permission name [1], so I really think this should go in branch nm09 in order to work fine with nm09.
[1] http://projects.gnome.org/NetworkManager/developers/migrating-to-09/ref-migrating.html
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am able to create/modify/delete wireless connections.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/NetworkManager/nmdbussettingsconnectionprovider.cpp <span style="color: grey">(cfb241d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101274/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>