<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100975/">http://git.reviewboard.kde.org/r/100975/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e48256bca53f402abfcf698525790d717961c0b2 by Lamarque V. Souza.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 30th, 2011, 5:37 p.m., Andrey Borzenkov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Andrey Borzenkov.</div>
<p style="color: grey;"><i>Updated March 30, 2011, 5:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently secrets are stuck in wallet forever. This patch adds method to delete them and applies it when connection is deleted. As it touches rather sensitive issues I would like public review.
Existing remnants still need to be removed manually.
TODO: ensure plain text secrets are deleted when encrypted storage is configured (is mostly mechanical - set secrets to "" - but touches many files so I'd like to postpone it until systemwide patch is settled)
TODO: ensure secrets are moved as appropriate when storage type is changed. I am still not sure where to do it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on top of systemwide and works there. Compile-tested on top of master.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/internals/connectionpersistence.h <span style="color: grey">(26985cbea6ab6e6d38117f931db437177943066a)</span></li>
<li>libs/internals/connectionpersistence.cpp <span style="color: grey">(7c52bb14b5f351fef74328c76bf4a26f3cc8f515)</span></li>
<li>settings/config/manageconnectionwidget.cpp <span style="color: grey">(15a6251f086a679e26eb212697c004de2b532ebd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100975/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>