<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101117/">http://git.reviewboard.kde.org/r/101117/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101117/diff/6/?file=14862#file14862line89" style="color: black; font-weight: bold; text-decoration: underline;">libs/ui/connectionwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ConnectionWidget::readConfig()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">ui</span><span class="p">.</span><span class="n">autoconnect</span><span class="o">-></span><span class="n">setChecked</span><span class="p">(</span><span class="n">connection</span><span class="p">()</span><span class="o">-></span><span class="n"><span class="hl">a</span>utoConnect</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">ui</span><span class="p">.</span><span class="n">autoconnect</span><span class="o">-></span><span class="n">setChecked</span><span class="p">(</span><span class="n">connection</span><span class="p">()</span><span class="o">-></span><span class="n"><span class="hl">originalA</span>utoConnect</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please ignore that, kinda got mixed up with another local branch.</pre>
</div>
<br />
<p>- Ilia</p>
<br />
<p>On April 20th, 2011, 6:22 p.m., Ilia Kats wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Ilia Kats.</div>
<p style="color: grey;"><i>Updated April 20, 2011, 6:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=270827">270827</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/NetworkManager/CMakeLists.txt <span style="color: grey">(a093415)</span></li>
<li>backends/NetworkManager/connectiondbus.cpp <span style="color: grey">(9c3c908)</span></li>
<li>backends/NetworkManager/settings/ipv4dbus.cpp <span style="color: grey">(7d167e9)</span></li>
<li>backends/NetworkManager/settings/ipv6dbus.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>backends/NetworkManager/settings/ipv6dbus.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/internals/CMakeLists.txt <span style="color: grey">(d5a0dab)</span></li>
<li>libs/internals/connection.cpp <span style="color: grey">(a5fe2d3)</span></li>
<li>libs/internals/connectionpersistence.cpp <span style="color: grey">(cc84af3)</span></li>
<li>libs/internals/schemas/ipv4.kcfg <span style="color: grey">(a069ef8)</span></li>
<li>libs/internals/schemas/ipv6.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/internals/schemas/ipv6.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/internals/setting.cpp <span style="color: grey">(197fafc)</span></li>
<li>libs/internals/settings/ipv4.h <span style="color: grey">(fee2987)</span></li>
<li>libs/internals/settings/ipv4.cpp <span style="color: grey">(6c6fd64)</span></li>
<li>libs/internals/settings/ipv4persistence.cpp <span style="color: grey">(c30622d)</span></li>
<li>libs/internals/settings/ipv6.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/internals/settings/ipv6.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/internals/settings/ipv6persistence.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/internals/settings/ipv6persistence.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/ui/CMakeLists.txt <span style="color: grey">(aea6563)</span></li>
<li>libs/ui/connectionwidget.cpp <span style="color: grey">(1968315)</span></li>
<li>libs/ui/gsmconnectioneditor.cpp <span style="color: grey">(39e7d3b)</span></li>
<li>libs/ui/ipv4.ui <span style="color: grey">(e107869)</span></li>
<li>libs/ui/ipv4widget.cpp <span style="color: grey">(732a94e)</span></li>
<li>libs/ui/ipv6.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/ui/ipv6advanced.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/ui/ipv6advancedwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/ui/ipv6advancedwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/ui/ipv6widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/ui/ipv6widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/ui/pppoepreferences.cpp <span style="color: grey">(be503c0)</span></li>
<li>libs/ui/simpleipv6addressvalidator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/ui/simpleipv6addressvalidator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/ui/vpnpreferences.cpp <span style="color: grey">(1714a51)</span></li>
<li>libs/ui/wiredpreferences.cpp <span style="color: grey">(003e05d)</span></li>
<li>libs/ui/wirelesspreferences.cpp <span style="color: grey">(7033c40)</span></li>
<li>solidcontrolfuture/CMakeLists.txt <span style="color: grey">(4643e8d)</span></li>
<li>solidcontrolfuture/networkipv6config.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solidcontrolfuture/networkipv6config.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101117/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101117/s/125/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/04/13/ipv6_1_400x100.png" style="border: 1px black solid;" alt="Basic settings" /></a>
<a href="http://git.reviewboard.kde.org/r/101117/s/126/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/04/13/ipv6_2_400x100.png" style="border: 1px black solid;" alt="advanced settings" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>