<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100947/">http://git.reviewboard.kde.org/r/100947/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 29th, 2011, 8 p.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100947/diff/4/?file=13242#file13242line22" style="color: black; font-weight: bold; text-decoration: underline;">backends/NetworkManager/settings/802-1xdbus.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Security8021xDbus::~Security8021xDbus()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">map</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="s">"eap"</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">map</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="s">"eap"</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Identation is broken here.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well ... can this be postponed until patch is a bit ironed out (or dropped, in which case it is non issue anyway)? This will create reformatting churn that just will distract from real changes. Same for two following comments?</pre>
<br />
<p>- Andrey</p>
<br />
<p>On March 29th, 2011, 7:36 p.m., Andrey Borzenkov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Andrey Borzenkov.</div>
<p style="color: grey;"><i>Updated March 29, 2011, 7:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch is based on work of Gökçen Eraslan and extends it by retrofitting user connections support. Design summary:
kded gets system wide connections from NM org.freedesktop.NetworkManagerSystemSettings and reads user connections directly from disk and exports them via org.freedesktop.NetworkManagerUserSettings
Connections, received from org.freedesktop.NetworkManagerSystemSettings, are marked as having System scope; connections read from disk are marked as having User scope.
KCM module (manage connections widget) does the same. Additionally, it checks whether user marked connection as System connection and forwards it to NM or saves directly on disk.
Plasma applet is not touched and continues to receive activatables list from kded, which is now merged list of system + user connections.
The patch set of Gökçen changed parts of KNM core to act directly on Connection object to handle connections received via D-Bus. My patches additionally move connection storing up from connectioneditor into manageconnectionwidet, so lower code does not need to know whether connection is user or systemwide.
Additionally handling of VPN plugins for systemwide connections (or more general - for connections from D-Bus) is fixed.
As discussed on ml, patch is against current master and includes both Gökçen and my changes. Breakdown is available in my clone repository in branch systemwide.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am using it myself and am able to see and use system connections. User connections work as well (tested with VPN). Creation of user connections work; system connections not tested so far. According to information I got system connections were successfully used by at least one distribution.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=204340">204340</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applet/networkmanager.cpp <span style="color: grey">(f60c55041076184d8e5e195d15424905f18c1468)</span></li>
<li>backends/NetworkManager/CMakeLists.txt <span style="color: grey">(f6ff3720f293b0e1acc59a08a06bd9504af5d933)</span></li>
<li>backends/NetworkManager/connectiondbus.h <span style="color: grey">(428429bf6cb2bba1173ccbeddf6c9b5b8d4817ad)</span></li>
<li>backends/NetworkManager/connectiondbus.cpp <span style="color: grey">(4a142e9b23dc7de217377e29ad2b8a3fbcf64422)</span></li>
<li>backends/NetworkManager/generateDbusAdapters.sh <span style="color: grey">(58f2e006a937b6284bbf8b4c48c7acda38cc5075)</span></li>
<li>backends/NetworkManager/nm-exported-connection-secrets-interface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>backends/NetworkManager/nm-exported-connection-secrets-interface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>backends/NetworkManager/nmdbussettingsconnectionprovider.h <span style="color: grey">(3245f84e850fd5de0fea802207663acd7da77737)</span></li>
<li>backends/NetworkManager/nmdbussettingsconnectionprovider.cpp <span style="color: grey">(b7996941296708518042ed192a3d58430ff50aae)</span></li>
<li>backends/NetworkManager/settings/802-11-wireless-securitydbus.cpp <span style="color: grey">(46671034114d626a38f89bf9056680daacf3ec73)</span></li>
<li>backends/NetworkManager/settings/802-11-wirelessdbus.cpp <span style="color: grey">(05bc049bb031c301d61d8c4c7b7314f428d6ca97)</span></li>
<li>backends/NetworkManager/settings/802-1xdbus.cpp <span style="color: grey">(0707ee2354d2207da2cc13ad96fd9b77b887ac71)</span></li>
<li>backends/NetworkManager/settings/gsmdbus.cpp <span style="color: grey">(9912df6eee8908bcf407b5fb26e91fca8afd52f3)</span></li>
<li>backends/NetworkManager/settings/ipv4dbus.cpp <span style="color: grey">(f77d421039e03953c04fe228a7b66b5c7033592d)</span></li>
<li>backends/NetworkManager/settings/pppoedbus.cpp <span style="color: grey">(e889177d0963214e4278c0b1a6adfbd959e560bf)</span></li>
<li>libs/client/remoteactivatablelist.cpp <span style="color: grey">(035531fc21a073dbafe2f191ae8114d7b0761625)</span></li>
<li>libs/internals/connection.h <span style="color: grey">(8c6978270213d3dfe491f4478253379f3c5cc0fb)</span></li>
<li>libs/internals/connection.cpp <span style="color: grey">(fdf34314894f60ca9b4311ebc1d02e40745efda4)</span></li>
<li>libs/internals/connectionpersistence.cpp <span style="color: grey">(7c52bb14b5f351fef74328c76bf4a26f3cc8f515)</span></li>
<li>libs/internals/settings/802-11-wireless-security.h <span style="color: grey">(a9328bb1af579013ee1184c3e4935ef87e1735e1)</span></li>
<li>libs/internals/settings/802-11-wireless-security.cpp <span style="color: grey">(a803c61b7022c604e129cd1014b72348526559e0)</span></li>
<li>libs/internals/settings/802-11-wireless-securitypersistence.cpp <span style="color: grey">(f223d92213d33fc1970e6f153a8e84accd2350b3)</span></li>
<li>libs/internals/settings/802-11-wireless.h <span style="color: grey">(12839800c4256d5a05a8f70cab4a2aa5e35914d7)</span></li>
<li>libs/internals/settings/802-1x.cpp <span style="color: grey">(f3bdb3724b043270196aebacf90b8cac85f9f8ea)</span></li>
<li>libs/internals/settings/802-3-ethernet.h <span style="color: grey">(24d64a2dd0888bd19f57d2e5e4af45a172ad13d5)</span></li>
<li>libs/internals/settings/gsm.h <span style="color: grey">(b380af09ab419059d344c3856415b2b446314f12)</span></li>
<li>libs/internals/settings/gsmpersistence.cpp <span style="color: grey">(ce87fbe9a05a2bed8ab12bd9cd36bdfb44ad2e8a)</span></li>
<li>libs/service/connectionlistpersistence.cpp <span style="color: grey">(b90e8cf3bb866445b81b03ec8a28475cd36df309)</span></li>
<li>libs/ui/802_11_wirelesswidget.cpp <span style="color: grey">(b654bc42aad578bbee83eea7ca8d856744ebe020)</span></li>
<li>libs/ui/cdmaconnectioneditor.h <span style="color: grey">(b3e53d3414ee6b27b75a5afeee7df7b90768058d)</span></li>
<li>libs/ui/cdmaconnectioneditor.cpp <span style="color: grey">(f12638e2cd98903f97c323c7420a28c783ba3c9a)</span></li>
<li>libs/ui/connection.ui <span style="color: grey">(b6e9bb7390a931bdfc45b15a835d117a0242f191)</span></li>
<li>libs/ui/connectioneditor.h <span style="color: grey">(423de5a393a88f20818ddf790678eb2e38d7439d)</span></li>
<li>libs/ui/connectioneditor.cpp <span style="color: grey">(e8831d59b182fd0198bd0f7ff292f10347b857be)</span></li>
<li>libs/ui/connectionprefs.h <span style="color: grey">(4a36dfadda71f5fae820480bbaa8fc74d6b72e6b)</span></li>
<li>libs/ui/connectionprefs.cpp <span style="color: grey">(f532dbb4b97e069e8f7be69311d8eff094127e6b)</span></li>
<li>libs/ui/connectionsecretsjob.cpp <span style="color: grey">(fce537afe3f8e598d556733e18560c8aa803919d)</span></li>
<li>libs/ui/connectionwidget.cpp <span style="color: grey">(47daa17979305577322f01d48a4f107894df7d1c)</span></li>
<li>libs/ui/gsm.ui <span style="color: grey">(eeaaa41281cd383f7d7adeda07dd6d4c63c1c97e)</span></li>
<li>libs/ui/gsmconnectioneditor.h <span style="color: grey">(2a3ccb1bab86f73158a2f8c384d50ca8dd7af1d5)</span></li>
<li>libs/ui/gsmconnectioneditor.cpp <span style="color: grey">(5a26c7ce3b1fad946b065fced45ed4dc7cb207ef)</span></li>
<li>libs/ui/gsmwidget.cpp <span style="color: grey">(82e015a9206ce3c1167e5728eaa1dd8959230d94)</span></li>
<li>libs/ui/networkmanagement_vpnuiplugin.desktop <span style="color: grey">(695cb6d65745a7d317b79140755acd8a9929d179)</span></li>
<li>libs/ui/pppoepreferences.h <span style="color: grey">(6f391506f4d30008e82041a923e5dde107134a84)</span></li>
<li>libs/ui/pppoepreferences.cpp <span style="color: grey">(0cabcd0ae5e2548132271311f5f0defd7aa797e3)</span></li>
<li>libs/ui/security/eapmethodstack.h <span style="color: grey">(552f5c9d0a1de16879f3e9c804ebe6faeaf7363e)</span></li>
<li>libs/ui/security/eapmethodstack.cpp <span style="color: grey">(e89e8874af86661c1bece00c97068fb100eba524)</span></li>
<li>libs/ui/security/nullsecuritywidget.h <span style="color: grey">(a0faa4643e4a9c0841313170364a0d2c489f70ef)</span></li>
<li>libs/ui/security/nullsecuritywidget.cpp <span style="color: grey">(5edc5cd2b2459c38ab0d2e1201951f445d8f2f83)</span></li>
<li>libs/ui/security/securityeap.h <span style="color: grey">(26ed2035bcdaec977ae4453a2cd470061e37838e)</span></li>
<li>libs/ui/security/securityeap.cpp <span style="color: grey">(db35037ceb4653b7de34734509dffbaed307d0a8)</span></li>
<li>libs/ui/security/securityleap.h <span style="color: grey">(5d9b0341c2ae724f297c893e7246b7264709810f)</span></li>
<li>libs/ui/security/securityleap.cpp <span style="color: grey">(95ba530a92f9d1aa083c82505904fe3c57ec52d5)</span></li>
<li>libs/ui/security/securitywidget.h <span style="color: grey">(71ebf4aede355a8434a3cc06e71fc19dcd12fba4)</span></li>
<li>libs/ui/security/securitywidget.cpp <span style="color: grey">(53cdc5e7ffe98152c9f95191bd788ae9970987e4)</span></li>
<li>libs/ui/security/securitywidget_p.h <span style="color: grey">(6ec8d9c2dcfe367647c12bff6f3e2491b0a6388d)</span></li>
<li>libs/ui/security/wepwidget.h <span style="color: grey">(e78338c6bb79dd5de4bf529b39b8fd4a62c87738)</span></li>
<li>libs/ui/security/wepwidget.cpp <span style="color: grey">(88b422f4df9dd1631e147f33c137aa210bfe03ee)</span></li>
<li>libs/ui/security/wirelesssecuritysettingwidget.cpp <span style="color: grey">(6fff4a6a017534b593e8e1281c0c34a24786bb96)</span></li>
<li>libs/ui/security/wpapskwidget.h <span style="color: grey">(70778367a6b5d8db9b2248437730f2316f572450)</span></li>
<li>libs/ui/security/wpapskwidget.cpp <span style="color: grey">(d2d221d196da3304d91cc45105bbdaed1fd2b813)</span></li>
<li>libs/ui/vpnpreferences.h <span style="color: grey">(39dd52b7f5414138fc8bfa1e80f08cbf8cb2414c)</span></li>
<li>libs/ui/vpnpreferences.cpp <span style="color: grey">(5274d14f734d0e42481487df6147c760b7f4141c)</span></li>
<li>libs/ui/wiredpreferences.h <span style="color: grey">(59b4f16574f2ad317bdc27a3d842e04f1caed1f7)</span></li>
<li>libs/ui/wiredpreferences.cpp <span style="color: grey">(60b79327bdf7bca44609d62efd969711315f42ed)</span></li>
<li>libs/ui/wiredwidget.cpp <span style="color: grey">(2229f74469e1a9dad7c448dcf55a6651b5796f48)</span></li>
<li>libs/ui/wirelesspreferences.h <span style="color: grey">(5d6a30c33809a7897d9667d58431d0fe630e5c6b)</span></li>
<li>libs/ui/wirelesspreferences.cpp <span style="color: grey">(7f901c272c3371fe920f4c790d6158502fc10b62)</span></li>
<li>monolithic/tooltipbuilder.cpp <span style="color: grey">(a09734a5d5f17ddebd679dc3941b1ef232a87b74)</span></li>
<li>settings/config/CMakeLists.txt <span style="color: grey">(0d4cd0020e80de765869a84363267a581893ba13)</span></li>
<li>settings/config/manageconnectionwidget.h <span style="color: grey">(c0fccd9b6b987300a5df854581a1698cd88df956)</span></li>
<li>settings/config/manageconnectionwidget.cpp <span style="color: grey">(15a6251f086a679e26eb212697c004de2b532ebd)</span></li>
<li>settings/config/managetraywidget.cpp <span style="color: grey">(38680ce8b73d587e683df0af0da28b0c971d0434)</span></li>
<li>settings/config/mobileproviders.cpp <span style="color: grey">(1ef26fcddeded9e612571a3fd4d1e0771e763bce)</span></li>
<li>settings/configshell/CMakeLists.txt <span style="color: grey">(d900ae726783ff416bbe7d5dababdec32217de15)</span></li>
<li>settings/configshell/main.cpp <span style="color: grey">(43248e21d1b99b7e591664315968819fa75a798b)</span></li>
<li>vpnplugins/novellvpn/networkmanagement_novellvpnui.desktop <span style="color: grey">(6bc2b5671d8ae531afb8717726de34757e75e660)</span></li>
<li>vpnplugins/openvpn/networkmanagement_openvpnui.desktop <span style="color: grey">(33b2b893bfcaad3e8343aa1dc10a5c3aa0f7afe6)</span></li>
<li>vpnplugins/pptp/networkmanagement_pptpui.desktop <span style="color: grey">(95a6bf7e76f3fa649a4763f482d7bd5b75181086)</span></li>
<li>vpnplugins/strongswan/networkmanagement_strongswanui.desktop <span style="color: grey">(a5b016eb31ce8e4345292d25a8e36762cb7fe70b)</span></li>
<li>vpnplugins/vpnc/networkmanagement_vpncui.desktop <span style="color: grey">(b4081121a5684a9154500e0e6f64442ea6f21417)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100947/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>