<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100856/">http://git.reviewboard.kde.org/r/100856/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100856/diff/1/?file=11365#file11365line97" style="color: black; font-weight: bold; text-decoration: underline;">libs/internals/connection.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">97</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Check if any of the settings in this connection have secrets</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">97</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Check if any of the settings in this connection have secrets</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not familiar with VPN code in networkmanagement. The patch seems ok, although have not tested it myself.</pre>
</div>
<br />
<p>- Lamarque Vieira</p>
<br />
<p>On March 14th, 2011, 6:07 p.m., Andrey Borzenkov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Andrey Borzenkov.</div>
<p style="color: grey;"><i>Updated March 14, 2011, 6:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch series b1810..a1115e introduced the following regression:
Same function was misused for both "secrets were loaded from
stable storage" as well as "are there any volatile secrets".
Additionally, secretsAvailable() never really checked whether
secrets were loaded at all.
The patch reverts secretsAvailable() semantic to "secrets loaded
from stable storage" and adds additionally hasVolatileSecrets()
to check whether any secret is never stored and has to be always
asked from user.
Addtitionally doAskUser() never really reset error after user
supplied secrets so connection hung. Fixed as well.
Fixes https://bugs.kde.org/show_bug.cgi?id=262555
Special thanks to Xeno for providing exceptional good test case.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing was done under current GIT using real OpenVPN server</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=262555">262555</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/internals/connection.h <span style="color: grey">(752ae78)</span></li>
<li>libs/internals/connection.cpp <span style="color: grey">(2914b39)</span></li>
<li>libs/internals/setting.h <span style="color: grey">(ec16bf1)</span></li>
<li>libs/internals/settings/vpn.h <span style="color: grey">(d809c79)</span></li>
<li>libs/internals/settings/vpn.cpp <span style="color: grey">(4186655)</span></li>
<li>libs/internals/settings/vpnpersistence.cpp <span style="color: grey">(cffbe53)</span></li>
<li>libs/ui/connectionsecretsjob.cpp <span style="color: grey">(5a90b99)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100856/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>