<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100674/">http://git.reviewboard.kde.org/r/100674/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 17th, 2011, 3:35 p.m., <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch looks good, apart from some minor coding style issues. Please fix those and commit.
(I haven't tested it, but trust those that have =)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">done, thanks!
http://quickgit.kde.org/?p=networkmanagement.git&a=commit&h=e6a2b8626c998f5ebc2e6bf0bf927462201e039d</pre>
<br />
<p>- Rex</p>
<br />
<p>On February 17th, 2011, 3:24 p.m., Rex Dieter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Rex Dieter.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2011, 3:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">BSSID is provided in a bad format to NM daemon, which causes connection failures. Also, MAC address is not sent correctly
when you use "Restrict to Interface" combo. For WiFi that causes connection failure, for wired the setting is just
ignored.
See also, https://bugs.kde.org/show_bug.cgi?id=238046
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch has been tested in the wild in fedora for awhile, a gentoo user in aforementioned bug reports success as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/NetworkManager/settingdbus.h <span style="color: grey">(e0ef8ba)</span></li>
<li>backends/NetworkManager/settingdbus.cpp <span style="color: grey">(20a4dc9)</span></li>
<li>backends/NetworkManager/settings/802-11-wirelessdbus.cpp <span style="color: grey">(3ba8964)</span></li>
<li>backends/NetworkManager/settings/802-3-ethernetdbus.cpp <span style="color: grey">(7d730c1)</span></li>
<li>libs/ui/802_11_wirelesswidget.cpp <span style="color: grey">(e671443)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100674/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>