<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6054/">http://svn.reviewboard.kde.org/r/6054/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, please commit. :)</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On December 5th, 2010, 7:18 p.m., Andy Goossens wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management and KNetworkManager.</div>
<div>By Andy Goossens.</div>
<p style="color: grey;"><i>Updated 2010-12-05 19:18:53</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support for password protected keys when using OpenVPN. This fixes long standing bug 150680.
I have added a text field called "Key password" to the configuration parameters for connection types "Certificates" and "Certificates with password". At the same time I fixed other issues in the UI file: changed tab order, added missing buddy's and masked password fields.
The rest was easy: the "Key password" value will be stored as a "secret". The NetworkManager daemon receives this "cert-pass" value and connects successfully.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested "Certificates" mode with and without a password protected key. In case your key is not protected, you should not fill in the "Key password" field. But if you do, it will be erased after a successful login (I believe this is caused by NetworkManager sending us updated data). Not really an issue IMO.
I also tested "Certificates with password" mode. I do not have such a setup, but it seems to work in the same way as "Certificates" and ignores my provided username/password values.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=150680">150680</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/extragear/base/networkmanagement/vpnplugins/openvpn/openvpnprop.ui <span style="color: grey">(1203426)</span></li>
<li>trunk/extragear/base/networkmanagement/vpnplugins/openvpn/openvpnwidget.cpp <span style="color: grey">(1203426)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6054/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>