<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129673/">https://git.reviewboard.kde.org/r/129673/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 23rd, 2016, 1:24 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>[toni@toni-pc dragon]$ rbt post -r 129673 --diff-filename=actions.patch --server https://git.reviewboard.kde.org -p -d --repository=dragon
>>> RBTools 0.7.6
>>> Python 2.7.12 (default, Jul 3 2016, 21:49:11)
[GCC 5.4.0]
>>> Running on Linux-4.8.6-1-x86_64-with-glibc2.2.5
>>> Home = /home/toni
>>> Current directory = /home/toni/dragon
>>> Checking for a Subversion repository...
>>> Unable to execute "svn help": skipping SVN
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Running: git config core.bare
>>> Running: git rev-parse --show-toplevel
>>> Running: git symbolic-ref -q HEAD
>>> Running: git config --get branch.Applications/16.12.merge
>>> Running: git config --get branch.Applications/16.12.remote
>>> Running: git config --get remote.origin.url
>>> repository info: Path: kde:dragon, Base path: , Supports changesets: False
>>> Making HTTP GET request to https://git.reviewboard.kde.org/api/
>>> Making HTTP GET request to https://git.reviewboard.kde.org/api/validation/diffs/
>>> Cached response for HTTP GET https://git.reviewboard.kde.org/api/validation/diffs/ expired and was modified
>>> Making HTTP POST request to https://git.reviewboard.kde.org/api/validation/diffs/
>>> Got API Error 224 (HTTP code 400): fatal: git cat-file 4fa56180cbd72a9797fc8623f8212a8468a93d2b: bad file
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'fatal: git cat-file 4fa56180cbd72a9797fc8623f8212a8468a93d2b: bad file\n', u'code': 224}}
Traceback (most recent call last):
File "/usr/bin/rbt", line 11, in <module>
load_entry_point('RBTools==0.7.6', 'console_scripts', 'rbt')()
File "/usr/lib/python2.7/site-packages/RBTools-0.7.6-py2.7.egg/rbtools/commands/main.py", line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File "/usr/lib/python2.7/site-packages/RBTools-0.7.6-py2.7.egg/rbtools/commands/__init__.py", line 629, in run_from_argv
exit_code = self.main(*args) or 0
File "/usr/lib/python2.7/site-packages/RBTools-0.7.6-py2.7.egg/rbtools/commands/post.py", line 756, in main
(msg_prefix, e))
rbtools.commands.CommandError: Error validating diff
fatal: git cat-file 4fa56180cbd72a9797fc8623f8212a8468a93d2b: bad file
(HTTP 400, API Error 224)
</pre></div>
</p></pre>
</blockquote>
<p>On December 23rd, 2016, 1:34 p.m. UTC, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems more like a client side problem with your dragon repo more than anything. Perhaps try on a new clone.</p></pre>
</blockquote>
<p>On December 23rd, 2016, 1:43 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I commit changes to my repo and then make new patches, error happens after first commit, mostly.</p></pre>
</blockquote>
<p>On December 23rd, 2016, 1:54 p.m. UTC, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd suggest instead creating one branch per review and putting everything for that review into that branch. Then use rbt post to let rbt figure out the changes and generate the review diff automatically. Most of the time this will work fine. It's also the preferred workflow once KDE fully switches to phabricator for reviews. If you really want to do patch files tough, you can also upload those manually on the reviewboard webui to generate a new review.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://community.kde.org/Infrastructure/Review_Board#Using_Review_Board_the_easy_way</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Reviewboard does not support anything other than making patches on top of the current upstream state of the repository. If you make local commits and don't push them then you will see errors such as the one you got above.</p></pre>
<br />
<p>- Ben</p>
<br />
<p>On December 23rd, 2016, 5:40 a.m. UTC, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia and Harald Sitter.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2016, 5:40 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dragon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ability to remove item and clear list from keyboard shortcut</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/app/recentlyPlayedList.cpp <span style="color: grey">(2c25e7f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129673/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/20/fad5b9ab-9ffb-4220-a0f4-5a25845c6507__Screenshot_20161220_070541.png">Actions</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>