<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129651/">https://git.reviewboard.kde.org/r/129651/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Декември 14th, 2016, 12:15 след обяд EET, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Inhibiting is so very bad... </p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">org.freedesktop.PowerManagement is deprecated https://www.freedesktop.org/wiki/Specifications/power-management-spec/ there seems to be no information as to what it was deprecated in favor of though</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">we could use org.kde.Solid.PowerManagement but that would not work on !plasma as I understand it</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">we could use org.freedesktop.login1 https://www.freedesktop.org/wiki/Software/systemd/inhibit/ which would work everywhere but on plasma, as apparently powerdevil tells logind to shut up</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">there's this unlanded RR https://git.reviewboard.kde.org/r/126650/ which would kinda solve our problem, albeit also using org.freedesktop.PowerManagement</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Where to go from here I do not actually know. I'd rather not use org.freedesktop.PowerManagement given its depreated state, at the same time I am somewhat inclined to not care given every source code I checked is using it anyway. that being said the RR currently doesn't inhibit screensavers. </p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for the merge problem. When you commit to maintenance branches (i.e. Applications/) you need to manually merge them into master or any other relevant branches as well. There is no automatic merge and I am also only merging into master on-demand, when I make a change myself. To fix this it appears you can simply merge Applications/16.04 into Applications/16.12 and then Applications/16.12 into master</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QDBusInterface iface(QLatin1String("org.freedesktop.login1"),
QLatin1String("/org/freedesktop/login1"),
QLatin1String("org.freedesktop.login1.Manager"),
QDBusConnection::systemBus());
reply = iface.call(QLatin1String("Inhibit"),
QLatin1String("sleep:shutdown"),
i18n("Dragon Player"),
i18n("playing a video"),
QLatin1String("block"));
does not work</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Декември 14th, 2016, 12:15 след обяд EET, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129651/diff/1/?file=487471#file487471line820" style="color: black; font-weight: bold; text-decoration: underline;">src/app/mainWindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">818</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if 0</span><span class="c"> // kf5 FIXME port to new Solid::Power API</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">816</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">m_stopSleepCookie</span> <span class="o">==</span> <span class="o">-</span><span class="mi">1</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am pretty sure the inhibition port is lackluster. Notably KnotificationRestrictions inhibited screensaving which I am assuming doesn't fall into the PowerManagement domain so the new code while inhibiting sleeping it seems ot miss screensaver stuff.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fortunately knotificationrestrictions is ported and you can just keep on using it.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can we use only knotificationrestrictions, but sleep/suspend to not handle at all?</p></pre>
<br />
<p>- Anthony</p>
<br />
<p>On Декември 14th, 2016, 6:49 преди обяд EET, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia and Harald Sitter.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Дек. 14, 2016, 6:49 преди обяд</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dragon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since solid power api is not released, i use freedesktop dbus to fit other desktop power managers</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">*Harald master was not merged (16.04 / 16.08 to master) -> it has fresh bugreports for fixed issues.
Last merge to 16.08
2016-04-18 Merge branch 'Applications/16.04' Harald Sitter
after that in brach 16.04
2016-04-26 Hide toolbar on multiscreen setup Anthony Fieroni
2016-04-20 Don't try to resize maximized window Anthony Fieroni
2016-04-19 MPRIS2 property 'Identity' to match desktop file entry Anthony Fieroni</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do you want to merge them or you will ship ?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/app/mainWindow.cpp <span style="color: grey">(4f0b3e0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129651/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>