<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127196/">https://git.reviewboard.kde.org/r/127196/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 30th, 2016, 9:18 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127196/diff/1/?file=445679#file445679line228" style="color: black; font-weight: bold; text-decoration: underline;">mbmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">128</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">static</span> <span class="n">QList</span><span class="o"><</span><span class="n">MBTrackInfo</span><span class="o">></span> <span class="n">getTracks</span><span class="p">(</span><span class="n">MusicBrainz5</span><span class="o">::</span><span class="n">CMedium</span> <span class="o">*</span><span class="n">medium</span><span class="p">,</span> <span class="n">QString</span> <span class="o">&</span><span class="n">discArtist</span><span class="p">,</span> <span class="n">DiscId</span> <span class="o">*</span><span class="n">m_discid</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">can discArtist be const? same for other stuff in the previous/next functions that gets passed by reference</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It seems that it can, in getTracks and unknownTracks, also discId in getRelease, but I'm not currently being able to test it. As I'm getting a 503 in every request. :(</p></pre>
<br />
<p>- Maximiliano</p>
<br />
<p>On February 27th, 2016, 8:01 a.m. UTC, Maximiliano Curia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia and Torrie Fischer.</div>
<div>By Maximiliano Curia.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2016, 8:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kscd
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Migrate to musicbrainz5</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It works for me, but the musicbrainz services reply 503 often.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e8915067529df072ecde3a0bb5e54a870cd2621a)</span></li>
<li>cmake/FindDiscId.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/FindMusicBrainz5.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>kscd.h <span style="color: grey">(dcbdd57b1f5f18dc369ea8babd66fc4340553b31)</span></li>
<li>kscd.cpp <span style="color: grey">(3bcb8f664fa76143f33ef69cd28fa7116ee475ea)</span></li>
<li>mbmanager.h <span style="color: grey">(6b07e951adf12a34e4c946367b2708c73dd59fcf)</span></li>
<li>mbmanager.cpp <span style="color: grey">(4df3803afb13c788b9e0c0d49dbe7c20f00f3fd6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127196/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>