<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127741/">https://git.reviewboard.kde.org/r/127741/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127741/diff/9/?file=461867#file461867line107" style="color: black; font-weight: bold; text-decoration: underline;">kcmcddb/cddbconfigwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 9)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">106</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">ok</span> <span class="o">&&</span> <span class="n">result</span><span class="p">.</span><span class="n">count</span><span class="p">()</span> <span class="o">==</span> <span class="mi">1</span><span class="p">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">98</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">ok</span> <span class="o">&&</span> <span class="n">result</span><span class="p">.</span><span class="n">count</span><span class="p">()</span> <span class="o">==</span> <span class="mi">1</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is still wrong, result was a list, now it's a string, doing "result.count() == 1" is not doing what it was doing and it's totally wrong.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix.</p></pre>
</div>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On April 30th, 2016, 4:25 p.m. UTC, Angelo Scarna wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia and Harald Sitter.</div>
<div>By Angelo Scarna.</div>
<p style="color: grey;"><i>Updated April 30, 2016, 4:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkcddb
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port complete to KF5</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It has been successfully tested . Now I propose another passage , to bring k3b to KF5</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a92ff28)</span></li>
<li>kcmcddb/CMakeLists.txt <span style="color: grey">(6cd7822)</span></li>
<li>kcmcddb/cddbconfigwidget.cpp <span style="color: grey">(e7e3758)</span></li>
<li>kcmcddb/cddbconfigwidget.ui <span style="color: grey">(16fc911)</span></li>
<li>kcmcddb/doc/CMakeLists.txt <span style="color: grey">(a565b0b)</span></li>
<li>kcmcddb/kcmcddb.h <span style="color: grey">(5a9a712)</span></li>
<li>kcmcddb/kcmcddb.cpp <span style="color: grey">(00c8b9f)</span></li>
<li>kcmcddb/libkcddb.desktop <span style="color: grey">(d9224bf)</span></li>
<li>libkcddb/CMakeLists.txt <span style="color: grey">(8927d1a)</span></li>
<li>libkcddb/asynccddbplookup.cpp <span style="color: grey">(8cc7d23)</span></li>
<li>libkcddb/asynchttplookup.h <span style="color: grey">(6f3ee4a)</span></li>
<li>libkcddb/asynchttplookup.cpp <span style="color: grey">(bba91df)</span></li>
<li>libkcddb/asynchttpsubmit.cpp <span style="color: grey">(acc6205)</span></li>
<li>libkcddb/asyncsmtpsubmit.cpp <span style="color: grey">(3ea9702)</span></li>
<li>libkcddb/cache.h <span style="color: grey">(0f67c10)</span></li>
<li>libkcddb/cache.cpp <span style="color: grey">(96c9560)</span></li>
<li>libkcddb/categories.h <span style="color: grey">(c2d28fa)</span></li>
<li>libkcddb/categories.cpp <span style="color: grey">(222df47)</span></li>
<li>libkcddb/cddb.h <span style="color: grey">(202f1d9)</span></li>
<li>libkcddb/cddb.cpp <span style="color: grey">(9518f87)</span></li>
<li>libkcddb/cddbplookup.h <span style="color: grey">(6c4244c)</span></li>
<li>libkcddb/cddbplookup.cpp <span style="color: grey">(2f3c772)</span></li>
<li>libkcddb/cdinfo.h <span style="color: grey">(6322f59)</span></li>
<li>libkcddb/cdinfo.cpp <span style="color: grey">(ee1cd39)</span></li>
<li>libkcddb/cdinfodialog.h <span style="color: grey">(b52773e)</span></li>
<li>libkcddb/cdinfodialog.cpp <span style="color: grey">(e7f7839)</span></li>
<li>libkcddb/cdinfodialog.ui <span style="color: grey">(9ca3400)</span></li>
<li>libkcddb/cdinfoencodingwidget.cpp <span style="color: grey">(97f6071)</span></li>
<li>libkcddb/cdinfoencodingwidget.ui <span style="color: grey">(0f92cf7)</span></li>
<li>libkcddb/client.h <span style="color: grey">(136cab7)</span></li>
<li>libkcddb/client.cpp <span style="color: grey">(6ceb0f5)</span></li>
<li>libkcddb/genres.h <span style="color: grey">(d0fe2bb)</span></li>
<li>libkcddb/genres.cpp <span style="color: grey">(3af2558)</span></li>
<li>libkcddb/httplookup.h <span style="color: grey">(c4861ac)</span></li>
<li>libkcddb/httplookup.cpp <span style="color: grey">(9a43712)</span></li>
<li>libkcddb/httpsubmit.h <span style="color: grey">(a37f773)</span></li>
<li>libkcddb/httpsubmit.cpp <span style="color: grey">(402c98d)</span></li>
<li>libkcddb/kcddb.cpp <span style="color: grey">(b90873f)</span></li>
<li>libkcddb/kcddb_export.h <span style="color: grey">(6ac6d57)</span></li>
<li>libkcddb/kcddbconfig.cpp <span style="color: grey">(27f2a34)</span></li>
<li>libkcddb/kcddbdebug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkcddb/lookup.h <span style="color: grey">(5b5556b)</span></li>
<li>libkcddb/lookup.cpp <span style="color: grey">(d3ec89a)</span></li>
<li>libkcddb/musicbrainz/asyncmusicbrainzlookup.h <span style="color: grey">(373fb16)</span></li>
<li>libkcddb/musicbrainz/asyncmusicbrainzlookup.cpp <span style="color: grey">(c13c94f)</span></li>
<li>libkcddb/musicbrainz/musicbrainzlookup.h <span style="color: grey">(5f0254f)</span></li>
<li>libkcddb/musicbrainz/musicbrainzlookup.cpp <span style="color: grey">(3364897)</span></li>
<li>libkcddb/sites.h <span style="color: grey">(3a4121b)</span></li>
<li>libkcddb/sites.cpp <span style="color: grey">(65a2e48)</span></li>
<li>libkcddb/smtpsubmit.h <span style="color: grey">(6a082b0)</span></li>
<li>libkcddb/smtpsubmit.cpp <span style="color: grey">(3e74ce9)</span></li>
<li>libkcddb/submit.h <span style="color: grey">(e46fedb)</span></li>
<li>libkcddb/submit.cpp <span style="color: grey">(99661cc)</span></li>
<li>libkcddb/synccddbplookup.h <span style="color: grey">(f13bcce)</span></li>
<li>libkcddb/synccddbplookup.cpp <span style="color: grey">(a4d9625)</span></li>
<li>libkcddb/synchttplookup.h <span style="color: grey">(3c89078)</span></li>
<li>libkcddb/synchttplookup.cpp <span style="color: grey">(bfe79d2)</span></li>
<li>libkcddb/synchttpsubmit.cpp <span style="color: grey">(7e13aa7)</span></li>
<li>libkcddb/syncsmtpsubmit.cpp <span style="color: grey">(19cc941)</span></li>
<li>test/CMakeLists.txt <span style="color: grey">(e2e2aab)</span></li>
<li>test/asynccddblookuptest.cpp <span style="color: grey">(03f79fe)</span></li>
<li>test/asynchttplookuptest.cpp <span style="color: grey">(3377987)</span></li>
<li>test/asynchttpsubmittest.cpp <span style="color: grey">(155ad98)</span></li>
<li>test/asyncmusicbrainztest.cpp <span style="color: grey">(4aea67e)</span></li>
<li>test/asyncsmtpsubmittest.cpp <span style="color: grey">(5ade7c9)</span></li>
<li>test/cachetest.cpp <span style="color: grey">(fd5bcb7)</span></li>
<li>test/cdinfotest.cpp <span style="color: grey">(69f98a8)</span></li>
<li>test/musicbrainztest-fulldate.cpp <span style="color: grey">(d1c4ad4)</span></li>
<li>test/musicbrainztest-severaldiscs.cpp <span style="color: grey">(e476a8b)</span></li>
<li>test/musicbrainztest.cpp <span style="color: grey">(95bef0b)</span></li>
<li>test/sitestest.cpp <span style="color: grey">(dd028fa)</span></li>
<li>test/synccddblookuptest.h <span style="color: grey">(01a750f)</span></li>
<li>test/synccddblookuptest.cpp <span style="color: grey">(6b6b28b)</span></li>
<li>test/synchttplookuptest.cpp <span style="color: grey">(c09f324)</span></li>
<li>test/synchttpsubmittest.cpp <span style="color: grey">(a107b9d)</span></li>
<li>test/syncsmtpsubmittest.cpp <span style="color: grey">(c957c6d)</span></li>
<li>test/utf8test.cpp <span style="color: grey">(83f7b3a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127741/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/30/fb3808aa-2b60-4f0f-8215-4923341d2501__libkcddb_kcm.png">libkcddb_kcm.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/30/54aa0356-907e-46f3-92d8-63ba639b44f7__libkcddb_kcm1.png">libkcddb_kcm1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/30/c1eda424-55ac-4177-a029-5dac1d3f5d86__libkcddb_main.png">libkcddb_main.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/30/55b2833d-9d35-4e17-8ba5-dc8301c96203__libkcddb_main1.png">libkcddb_main1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/30/f9cee02f-1494-4d4f-97b9-b30621aaa928__libkcddb_kcmshell5.png">libkcddb_kcmshell5.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>