<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127741/">https://git.reviewboard.kde.org/r/127741/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On aprile 25th, 2016, 8:37 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why did you copy MacroLogFeature?</p></pre>
</blockquote>
<p>On aprile 25th, 2016, 9:07 p.m. UTC, <b>Angelo Scarna</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Because it gave me error</p></pre>
</blockquote>
<p>On aprile 25th, 2016, 9:09 p.m. UTC, <b>Angelo Scarna</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why it was present in cmake modules for kde4</p></pre>
</blockquote>
<p>On aprile 25th, 2016, 10:16 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use upstream cmake <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">include(FeatureSummary)</code>. See its documentation or any other ported KDE project to see how it's used.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thank you so much , I updated and published the patch</p></pre>
<br />
<p>- Angelo</p>
<br />
<p>On aprile 26th, 2016, 6:34 p.m. UTC, Angelo Scarna wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia and Harald Sitter.</div>
<div>By Angelo Scarna.</div>
<p style="color: grey;"><i>Updated Apr. 26, 2016, 6:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkcddb
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port complete to KF5</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It has been successfully tested . Now I propose another passage , to bring k3b to KF5</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a92ff28)</span></li>
<li>kcmcddb/CMakeLists.txt <span style="color: grey">(6cd7822)</span></li>
<li>kcmcddb/cddbconfigwidget.h <span style="color: grey">(1cc9a8b)</span></li>
<li>kcmcddb/cddbconfigwidget.cpp <span style="color: grey">(e7e3758)</span></li>
<li>kcmcddb/cddbconfigwidget.ui <span style="color: grey">(16fc911)</span></li>
<li>kcmcddb/doc/CMakeLists.txt <span style="color: grey">(a565b0b)</span></li>
<li>kcmcddb/kcmcddb.h <span style="color: grey">(5a9a712)</span></li>
<li>kcmcddb/kcmcddb.cpp <span style="color: grey">(00c8b9f)</span></li>
<li>kcmcddb/libkcddb.desktop <span style="color: grey">(d9224bf)</span></li>
<li>libkcddb/CMakeLists.txt <span style="color: grey">(8927d1a)</span></li>
<li>libkcddb/asynccddbplookup.h <span style="color: grey">(0b2aa2a)</span></li>
<li>libkcddb/asynccddbplookup.cpp <span style="color: grey">(8cc7d23)</span></li>
<li>libkcddb/asynchttplookup.h <span style="color: grey">(6f3ee4a)</span></li>
<li>libkcddb/asynchttplookup.cpp <span style="color: grey">(bba91df)</span></li>
<li>libkcddb/asynchttpsubmit.h <span style="color: grey">(9dac9d6)</span></li>
<li>libkcddb/asynchttpsubmit.cpp <span style="color: grey">(acc6205)</span></li>
<li>libkcddb/asyncsmtpsubmit.h <span style="color: grey">(6eaeef8)</span></li>
<li>libkcddb/asyncsmtpsubmit.cpp <span style="color: grey">(3ea9702)</span></li>
<li>libkcddb/cache.h <span style="color: grey">(0f67c10)</span></li>
<li>libkcddb/cache.cpp <span style="color: grey">(96c9560)</span></li>
<li>libkcddb/categories.h <span style="color: grey">(c2d28fa)</span></li>
<li>libkcddb/categories.cpp <span style="color: grey">(222df47)</span></li>
<li>libkcddb/cddb.h <span style="color: grey">(202f1d9)</span></li>
<li>libkcddb/cddb.cpp <span style="color: grey">(9518f87)</span></li>
<li>libkcddb/cddbplookup.h <span style="color: grey">(6c4244c)</span></li>
<li>libkcddb/cddbplookup.cpp <span style="color: grey">(2f3c772)</span></li>
<li>libkcddb/cdinfo.h <span style="color: grey">(6322f59)</span></li>
<li>libkcddb/cdinfo.cpp <span style="color: grey">(ee1cd39)</span></li>
<li>libkcddb/cdinfodialog.h <span style="color: grey">(b52773e)</span></li>
<li>libkcddb/cdinfodialog.cpp <span style="color: grey">(e7f7839)</span></li>
<li>libkcddb/cdinfodialog.ui <span style="color: grey">(9ca3400)</span></li>
<li>libkcddb/cdinfoencodingwidget.h <span style="color: grey">(9c30950)</span></li>
<li>libkcddb/cdinfoencodingwidget.cpp <span style="color: grey">(97f6071)</span></li>
<li>libkcddb/cdinfoencodingwidget.ui <span style="color: grey">(0f92cf7)</span></li>
<li>libkcddb/client.h <span style="color: grey">(136cab7)</span></li>
<li>libkcddb/client.cpp <span style="color: grey">(6ceb0f5)</span></li>
<li>libkcddb/genres.h <span style="color: grey">(d0fe2bb)</span></li>
<li>libkcddb/genres.cpp <span style="color: grey">(3af2558)</span></li>
<li>libkcddb/httplookup.h <span style="color: grey">(c4861ac)</span></li>
<li>libkcddb/httplookup.cpp <span style="color: grey">(9a43712)</span></li>
<li>libkcddb/httpsubmit.h <span style="color: grey">(a37f773)</span></li>
<li>libkcddb/httpsubmit.cpp <span style="color: grey">(402c98d)</span></li>
<li>libkcddb/kcddb.h <span style="color: grey">(fca9fd8)</span></li>
<li>libkcddb/kcddb.cpp <span style="color: grey">(b90873f)</span></li>
<li>libkcddb/kcddb_export.h <span style="color: grey">(6ac6d57)</span></li>
<li>libkcddb/kcddbconfig.h <span style="color: grey">(7df5d4e)</span></li>
<li>libkcddb/kcddbconfig.cpp <span style="color: grey">(27f2a34)</span></li>
<li>libkcddb/lookup.h <span style="color: grey">(5b5556b)</span></li>
<li>libkcddb/lookup.cpp <span style="color: grey">(d3ec89a)</span></li>
<li>libkcddb/musicbrainz/asyncmusicbrainzlookup.h <span style="color: grey">(373fb16)</span></li>
<li>libkcddb/musicbrainz/asyncmusicbrainzlookup.cpp <span style="color: grey">(c13c94f)</span></li>
<li>libkcddb/musicbrainz/musicbrainzlookup.h <span style="color: grey">(5f0254f)</span></li>
<li>libkcddb/musicbrainz/musicbrainzlookup.cpp <span style="color: grey">(3364897)</span></li>
<li>libkcddb/sites.h <span style="color: grey">(3a4121b)</span></li>
<li>libkcddb/sites.cpp <span style="color: grey">(65a2e48)</span></li>
<li>libkcddb/smtpsubmit.h <span style="color: grey">(6a082b0)</span></li>
<li>libkcddb/smtpsubmit.cpp <span style="color: grey">(3e74ce9)</span></li>
<li>libkcddb/submit.h <span style="color: grey">(e46fedb)</span></li>
<li>libkcddb/submit.cpp <span style="color: grey">(99661cc)</span></li>
<li>libkcddb/synccddbplookup.h <span style="color: grey">(f13bcce)</span></li>
<li>libkcddb/synccddbplookup.cpp <span style="color: grey">(a4d9625)</span></li>
<li>libkcddb/synchttplookup.h <span style="color: grey">(3c89078)</span></li>
<li>libkcddb/synchttplookup.cpp <span style="color: grey">(bfe79d2)</span></li>
<li>libkcddb/synchttpsubmit.h <span style="color: grey">(a88b289)</span></li>
<li>libkcddb/synchttpsubmit.cpp <span style="color: grey">(7e13aa7)</span></li>
<li>libkcddb/syncsmtpsubmit.h <span style="color: grey">(b2ff98e)</span></li>
<li>libkcddb/syncsmtpsubmit.cpp <span style="color: grey">(19cc941)</span></li>
<li>test/CMakeLists.txt <span style="color: grey">(e2e2aab)</span></li>
<li>test/asynccddblookuptest.h <span style="color: grey">(5ce40fb)</span></li>
<li>test/asynccddblookuptest.cpp <span style="color: grey">(03f79fe)</span></li>
<li>test/asynchttplookuptest.h <span style="color: grey">(bcddc58)</span></li>
<li>test/asynchttplookuptest.cpp <span style="color: grey">(3377987)</span></li>
<li>test/asynchttpsubmittest.h <span style="color: grey">(0f31f10)</span></li>
<li>test/asynchttpsubmittest.cpp <span style="color: grey">(155ad98)</span></li>
<li>test/asyncmusicbrainztest.h <span style="color: grey">(b56fdc2)</span></li>
<li>test/asyncmusicbrainztest.cpp <span style="color: grey">(4aea67e)</span></li>
<li>test/asyncsmtpsubmittest.h <span style="color: grey">(d053267)</span></li>
<li>test/asyncsmtpsubmittest.cpp <span style="color: grey">(5ade7c9)</span></li>
<li>test/cachetest.h <span style="color: grey">(6f8820d)</span></li>
<li>test/cachetest.cpp <span style="color: grey">(fd5bcb7)</span></li>
<li>test/cdinfotest.h <span style="color: grey">(12d4749)</span></li>
<li>test/cdinfotest.cpp <span style="color: grey">(69f98a8)</span></li>
<li>test/musicbrainztest-fulldate.h <span style="color: grey">(8ab56c1)</span></li>
<li>test/musicbrainztest-fulldate.cpp <span style="color: grey">(d1c4ad4)</span></li>
<li>test/musicbrainztest-severaldiscs.h <span style="color: grey">(87655f6)</span></li>
<li>test/musicbrainztest-severaldiscs.cpp <span style="color: grey">(e476a8b)</span></li>
<li>test/musicbrainztest.h <span style="color: grey">(df9d2b3)</span></li>
<li>test/musicbrainztest.cpp <span style="color: grey">(95bef0b)</span></li>
<li>test/sitestest.cpp <span style="color: grey">(dd028fa)</span></li>
<li>test/synccddblookuptest.h <span style="color: grey">(01a750f)</span></li>
<li>test/synccddblookuptest.cpp <span style="color: grey">(6b6b28b)</span></li>
<li>test/synchttplookuptest.h <span style="color: grey">(72e3ddc)</span></li>
<li>test/synchttplookuptest.cpp <span style="color: grey">(c09f324)</span></li>
<li>test/synchttpsubmittest.cpp <span style="color: grey">(a107b9d)</span></li>
<li>test/syncsmtpsubmittest.cpp <span style="color: grey">(c957c6d)</span></li>
<li>test/utf8test.h <span style="color: grey">(631dafd)</span></li>
<li>test/utf8test.cpp <span style="color: grey">(83f7b3a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127741/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>