<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127608/">https://git.reviewboard.kde.org/r/127608/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 8th, 2016, 9:30 a.m. UTC, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127608/diff/1/?file=455763#file455763line412" style="color: black; font-weight: bold; text-decoration: underline;">cmake/FindPhononInternal.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">412</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">try_compile</span><span class="p">(</span><span class="s">_compile_result</span> <span class="o">${</span><span class="nv">CMAKE_BINARY_DIR</span><span class="o">}</span> <span class="o">${</span><span class="nv">_source_file</span><span class="o">}</span> <span class="s">CMAKE_FLAGS</span> <span class="s2">"${CMAKE_CXX_FLAGS}"</span> <span class="s"><span class="hl">COMPILE_DEFINITIONS</span></span><span class="hl"> </span><span class="s2"><span class="hl">"${_include_dirs</span>}"</span> <span class="s">OUTPUT_VARIABLE</span> <span class="s">_compile_output_var</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">412</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">try_compile</span><span class="p">(</span><span class="s">_compile_result</span> <span class="o">${</span><span class="nv">CMAKE_BINARY_DIR</span><span class="o">}</span> <span class="o">${</span><span class="nv">_source_file</span><span class="o">}</span> <span class="s">CMAKE_FLAGS</span> <span class="s2">"${CMAKE_CXX_FLAGS}"</span> <span class="s"><span class="hl">INCLUDE_DIRECTORIES</span></span><span class="hl"> </span><span class="s2"><span class="hl">"${_include_dirs}"</span></span><span class="hl"> </span><span class="s"><span class="hl">LINK_LIBRARIES</span></span><span class="hl"> </span><span class="s2"><span class="hl">"${Qt5Core_LIBRARIES</span>}"</span> <span class="s">OUTPUT_VARIABLE</span> <span class="s">_compile_output_var</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Qt5Core_LIBRARIES wouldn't be defined for qt4 builds, would it?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Correct, so it's essentially a no-op in the Qt4 case</p></pre>
<br />
<p>- Rex</p>
<br />
<p>On April 7th, 2016, 6:31 p.m. UTC, Rex Dieter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Phonon, Daniel Vrátil, Hrvoje Senjan, and Harald Sitter.</div>
<div>By Rex Dieter.</div>
<p style="color: grey;"><i>Updated April 7, 2016, 6:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
phonon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Previous attempts to fixing include issues ends up throwing away all but the first include dir (and so include dir ordering can make success/failure non-deterministic). As a bonus, add LINK_LIBRARIES "${Qt5Core_LIBRARIES}" in visibility test (else it always fails due to new symbol versioning feature in qt-5.6).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry, this is technically fixing 2 things at once, so I can split it into separate submissions if you prefer.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">build succeeds trying to build phonon-qt5 only on rhel7 (previously always fails).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindPhononInternal.cmake <span style="color: grey">(9f6ab40)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127608/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>