<div dir="ltr">Cool, that's good!<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 19 October 2015 at 14:24, Rex Dieter <span dir="ltr"><<a href="mailto:rdieter@gmail.com" target="_blank">rdieter@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><span class="">
<table style="border:1px #c9c399 solid;border-radius:6px" bgcolor="#f9f3c9" cellpadding="12" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125541/" target="_blank">https://git.reviewboard.kde.org/r/125541/</a>
</td>
</tr>
</tbody></table>
<br>
</span><span class=""><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On October 10th, 2015, 10:45 a.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Please fix this new warning, then I think we have a winner.</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">CMake Warning (dev) at CMakeLists.txt:37 (find_package):
A logical block opening on the line</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit"></p><div style="background:#f8f8f8"><pre style="line-height:125%">/home/rdieter1/<a href="http://git.kde.org/phonon-gstreamer/cmake/FindGStreamer.cmake:16" target="_blank">git.kde.org/phonon-gstreamer/cmake/FindGStreamer.cmake:16</a> (IF)
</pre></div>
<p></p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">closes on the line</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit"></p><div style="background:#f8f8f8"><pre style="line-height:125%">/home/rdieter1/<a href="http://git.kde.org/phonon-gstreamer/cmake/FindGStreamer.cmake:21" target="_blank">git.kde.org/phonon-gstreamer/cmake/FindGStreamer.cmake:21</a> (ENDIF)
</pre></div>
<p></p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">with mis-matching arguments.</p></pre>
</blockquote>
</blockquote>
</span><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Looks like this is no longer needed, another review took care of this issue, <a href="https://git.reviewboard.kde.org/r/125690/" target="_blank">https://git.reviewboard.kde.org/r/125690/</a></p></pre><span class="HOEnZb"><font color="#888888">
<br>
<p>- Rex</p></font></span><span class="">
<br>
<p>On October 8th, 2015, 2:43 p.m. UTC, Luca Sartorelli wrote:</p>
<table style="border:1px #888a85 solid;border-radius:6px" bgcolor="#fefadf" cellpadding="12" cellspacing="0" width="100%">
<tbody><tr>
<td>
<div>Review request for Phonon and Phonon Backends.</div>
<div>By Luca Sartorelli.</div>
<p style="color:grey"><i>Updated Oct. 8, 2015, 2:43 p.m.</i></p>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
phonon-gstreamer
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">phonon-gstreamer doesn't build due to missing include path for gst/gstconfig.h, that my debian sid machine it's located inside the gstreamer library directory.</p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">phonon-gstreamer build properly</p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>cmake/FindGStreamer.cmake <span style="color:grey">(d7243d4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125541/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/e5ef6ee5-0ed6-468f-899f-5e3c9290afcb__CMakeLists.txt.patch" target="_blank">CMakeLists.txt</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/39135f1d-65ab-4e2f-8bf8-b2d9d0c86fcc__FindGStreamer.cmake.patch" target="_blank">FindGStreamer.cmake</a></li>
</td>
</tr>
</tbody></table>
</span></div>
</div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature">P Please consider the environment before printing this e-mail</div>
</div>