<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125022/">https://git.reviewboard.kde.org/r/125022/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2015, 9:23 a.m. UTC, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/125022/file/2455/" style="color: black; font-weight: bold; font-size: 9pt;">5.patch</a>
<p>5.patch</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is to be done via MPRIS not in dragon player, this change is pretty much not going to get landed ever.</pre>
</blockquote>
<p>On September 23rd, 2015, 2:01 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Full patch or name of notification?</p></pre>
</blockquote>
<p>On September 23rd, 2015, 2:29 p.m. UTC, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">entire patch</p></pre>
</blockquote>
<p>On September 23rd, 2015, 5:21 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you make it? I'm not familiar with MPRIS, but this feature is very sensitive when listen radios :)</p></pre>
</blockquote>
<p>On September 24th, 2015, 7:33 a.m. UTC, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Dragon is not a music player. The way you'd implement it though is you use the MPRIS api to get changes from any media player (including dragon) and then simply represent that. This could be done via a kded module or a plasma applet. Latter actually exists, but doesn't have notifications (by design I would think).</p></pre>
</blockquote>
<p>On September 24th, 2015, 7:23 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yeah, but if i implement in plasma applet, actually i made that, i can't notice when 'real' player send notification and twice code notification appear. Why we connot implement it in src/mpris2/mediaplayer2player.cpp in same way as patch?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Because dragon will not ever get an OSD. An OSD is only useful with audio and there even only with radio streams (what with dragon not having a playlist), and since dragon is not meant to be an audio player there is no place for an OSD.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You can make a plasmoid or kded module dedicated for dragon to show the notification. MPRIS2 allows you to differentiate players http://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry</p></pre>
<br />
<p>- Harald</p>
<br />
<p>On September 24th, 2015, 3:11 a.m. UTC, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia and Lukáš Tinkl.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Sept. 24, 2015, 3:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dragon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dragon fixes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1. Restore cursor after fullscreen video ends
2. Initialize analyzer on audio streams
3. Refresh recently played list after playback is stopped
4. Multiple applications support
5. Notifications for audio streams</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e2138c5)</span></li>
<li>misc/CMakeLists.txt <span style="color: grey">(5628302)</span></li>
<li>misc/dragonplayer.notifyrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>misc/dragonplayerui.rc <span style="color: grey">(38a15c5)</span></li>
<li>src/app/CMakeLists.txt <span style="color: grey">(2696e34)</span></li>
<li>src/app/audioView2.h <span style="color: grey">(cc94549)</span></li>
<li>src/app/audioView2.cpp <span style="color: grey">(98ca473)</span></li>
<li>src/app/loadView.h <span style="color: grey">(80eaddb)</span></li>
<li>src/app/loadView.cpp <span style="color: grey">(0ae65ec)</span></li>
<li>src/app/main.cpp <span style="color: grey">(2de3b35)</span></li>
<li>src/app/mainWindow.h <span style="color: grey">(bd9ac91)</span></li>
<li>src/app/mainWindow.cpp <span style="color: grey">(777467b)</span></li>
<li>src/app/recentlyPlayedList.h <span style="color: grey">(c4d70de)</span></li>
<li>src/app/videoWindow.cpp <span style="color: grey">(552069d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125022/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/7b5ffbf3-e5f2-4660-b833-cfca5a1f07ac__1.patch">1.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/5c9ee12f-4270-49b9-8612-f165a1e16a78__2.patch">2.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/bbb61993-80ff-4dc9-b8e9-6dbc317d429c__3.patch">3.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/eb66193f-8c4d-4202-84ad-ec60f3429c0c__5.patch">5.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/4578f490-d338-4dd2-9141-e842699da4a0__4.patch">4.patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>