<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125022/">https://git.reviewboard.kde.org/r/125022/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2015, 9:23 a.m. UTC, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/125022/file/2455/" style="color: black; font-weight: bold; font-size: 9pt;">5.patch</a>
<p>5.patch</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is to be done via MPRIS not in dragon player, this change is pretty much not going to get landed ever.</pre>
</blockquote>
<p>On September 23rd, 2015, 2:01 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Full patch or name of notification?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">entire patch</p></pre>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2015, 9:23 a.m. UTC, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/125022/file/2450/" style="color: black; font-weight: bold; font-size: 9pt;">1.patch</a>
<p>1.patch</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Firstly what problem are you actually trying to solve here?
Secondly this looks like a hack. A manually set cursor should reset as closely to where it was set as possible, the proposed change looks a lot like it's not clear which cursor override we are
resetting here.</pre>
</blockquote>
<p>On September 23rd, 2015, 2:01 p.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's not hack. m_cursorTimer is started to hide cursor on fullscreen video playback, when it's fired cursor is hidden, but when playback ends, without manually stop it, no one restore cursor state and he stay invisible.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It restores properly here.</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">play video</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">go fullscreen</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">cursor disappears after timeout</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">wait for video to stop playing</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">cursor resets to lefthand</li>
</ul></pre>
<br />
<p>- Harald</p>
<br />
<p>On September 23rd, 2015, 1:58 p.m. UTC, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia and Lukáš Tinkl.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2015, 1:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dragon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dragon fixes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1. Restore cursor after fullscreen video ends
2. Initialize analyzer on audio streams
3. Refresh recently played list after playback is stopped
4. Multiple applications support
5. Notifications for audio streams</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e2138c5)</span></li>
<li>misc/CMakeLists.txt <span style="color: grey">(5628302)</span></li>
<li>misc/dragonplayer.notifyrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>misc/dragonplayerui.rc <span style="color: grey">(38a15c5)</span></li>
<li>src/app/CMakeLists.txt <span style="color: grey">(2696e34)</span></li>
<li>src/app/audioView2.h <span style="color: grey">(cc94549)</span></li>
<li>src/app/audioView2.cpp <span style="color: grey">(98ca473)</span></li>
<li>src/app/loadView.h <span style="color: grey">(80eaddb)</span></li>
<li>src/app/loadView.cpp <span style="color: grey">(0ae65ec)</span></li>
<li>src/app/main.cpp <span style="color: grey">(2de3b35)</span></li>
<li>src/app/mainWindow.h <span style="color: grey">(bd9ac91)</span></li>
<li>src/app/mainWindow.cpp <span style="color: grey">(777467b)</span></li>
<li>src/app/recentlyPlayedList.h <span style="color: grey">(c4d70de)</span></li>
<li>src/app/videoWindow.cpp <span style="color: grey">(552069d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125022/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/7b5ffbf3-e5f2-4660-b833-cfca5a1f07ac__1.patch">1.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/5c9ee12f-4270-49b9-8612-f165a1e16a78__2.patch">2.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/bbb61993-80ff-4dc9-b8e9-6dbc317d429c__3.patch">3.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/ea4bdd85-5e34-43f0-8c0f-70a357e42529__4.patch">4.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/eb66193f-8c4d-4202-84ad-ec60f3429c0c__5.patch">5.patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>