<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121725/">https://git.reviewboard.kde.org/r/121725/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 28th, 2014, 9:37 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Shouldn't this rather be fixed in systray only forwarding single ticks to apps? I suppose most apps break with high precision scrolling in that regard, many of which are not under our control.</p></pre>
</blockquote>
<p>On December 28th, 2014, 10:41 p.m. UTC, <b>Xuetian Weng</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">SNI interface is designed to have the "delta" argument.
http://www.notmart.org/misc/statusnotifieritem/statusnotifieritem.html</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I agree with Xuetian Weng. delta is a part of the standard. Unfortunately it is very easy for developers to misinterpret, as the documentation about delta has always been ridicously bad. For example the document linked just say "<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The delta parameter represent the amount of scroll</em>" (no units given at all). The Qt documentation is much better, but even the Qt example on "QWheelEvent::delta ()" is broken for high-precision devices.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also I would like to stress the solution presented in this review follows exactly recommendations from Qt: "<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">To support this possibility, you can either cumulatively add the delta values from events [...]</em>". A sentence which is important, but easy to miss (I also did).</p></pre>
<br />
<p>- Christian</p>
<br />
<p>On December 28th, 2014, 9 p.m. UTC, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia and Christian Esken.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2014, 9 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=313579">313579</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=341536">341536</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmix
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">High-precision scroll is going to send scroll event with multiple small delta event. A simple way to fix it is to round it by 120 for a single increment.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The problem in 313579 is that the delta value is directly divided by 120. This patch add all delta value up and round it by 120.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Plasma 5 + kmix scroll with trackpad.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gui/kmixdockwidget.h <span style="color: grey">(a0d7a46)</span></li>
<li>gui/kmixdockwidget.cpp <span style="color: grey">(eeccb36)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121725/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>